repo stringclasses 358
values | pull_number int64 6 67.9k | instance_id stringlengths 12 49 | issue_numbers listlengths 1 7 | base_commit stringlengths 40 40 | patch stringlengths 87 101M | test_patch stringlengths 72 22.3M | problem_statement stringlengths 3 256k | hints_text stringlengths 0 545k | created_at stringlengths 20 20 | PASS_TO_PASS listlengths 0 0 | FAIL_TO_PASS listlengths 0 0 |
|---|---|---|---|---|---|---|---|---|---|---|---|
aws-cloudformation/cfn-lint | 1,144 | aws-cloudformation__cfn-lint-1144 | [
"1141"
] | 9a42be5007813de4a7d1742264f5a991193b8273 | diff --git a/src/cfnlint/rules/functions/SubNeeded.py b/src/cfnlint/rules/functions/SubNeeded.py
--- a/src/cfnlint/rules/functions/SubNeeded.py
+++ b/src/cfnlint/rules/functions/SubNeeded.py
@@ -18,6 +18,7 @@
from cfnlint.rules import CloudFormationLintRule
from cfnlint.rules import RuleMatch
+
class SubNeeded(Clo... | diff --git a/test/fixtures/templates/good/functions/sub_needed.yaml b/test/fixtures/templates/good/functions/sub_needed.yaml
--- a/test/fixtures/templates/good/functions/sub_needed.yaml
+++ b/test/fixtures/templates/good/functions/sub_needed.yaml
@@ -18,6 +18,60 @@ Resources:
Action:
- "iam:Uplo... | E1029 - False positive with IAM policy Redshift condition keys
*cfn-lint version: (`cfn-lint --version`)*
cfn-lint 0.24.1
*Description of issue.*
${redshift:DbUser} triggers:
`E1029:Found an embedded parameter outside of an "Fn::Sub"`
I'm defining a policy document similar to the one below. cfn-lint returns a... | 2019-09-28T12:22:09Z | [] | [] | |
aws-cloudformation/cfn-lint | 1,151 | aws-cloudformation__cfn-lint-1151 | [
"1127"
] | 32bc877d4eb556d8bdf3f7f40a171826de0f20d0 | diff --git a/src/cfnlint/__init__.py b/src/cfnlint/__init__.py
--- a/src/cfnlint/__init__.py
+++ b/src/cfnlint/__init__.py
@@ -229,16 +229,23 @@ def get_valid_getatts(self):
results = {}
resources = self.template.get('Resources', {})
- astrik_types = (
- 'Custom::', 'AWS::CloudForm... | diff --git a/test/fixtures/templates/good/functions/join.yaml b/test/fixtures/templates/good/functions/join.yaml
--- a/test/fixtures/templates/good/functions/join.yaml
+++ b/test/fixtures/templates/good/functions/join.yaml
@@ -45,4 +45,26 @@ Resources:
- Fn::Join:
- ''
- !Ref ... | E1022 Fn::Join must use a list - fails with CloudFormation Custom Resource
*cfn-lint version: 0.21.4*
E1022 helpfully checks Fn::Join arguments for their type as a list; however, it is not able to recognize CloudFormation Custom Resource outputs as possible lists.
The following template launches successfully:
``... | 2019-09-30T01:55:19Z | [] | [] | |
aws-cloudformation/cfn-lint | 1,212 | aws-cloudformation__cfn-lint-1212 | [
"1211"
] | 71b6848fe0137f3492bb615284ac7541bfeb1596 | diff --git a/src/cfnlint/rules/resources/properties/Properties.py b/src/cfnlint/rules/resources/properties/Properties.py
--- a/src/cfnlint/rules/resources/properties/Properties.py
+++ b/src/cfnlint/rules/resources/properties/Properties.py
@@ -68,65 +68,79 @@ def primitivetypecheck(self, value, primtype, proppath):
... | diff --git a/test/fixtures/templates/bad/object_should_be_list.yaml b/test/fixtures/templates/bad/object_should_be_list.yaml
--- a/test/fixtures/templates/bad/object_should_be_list.yaml
+++ b/test/fixtures/templates/bad/object_should_be_list.yaml
@@ -668,6 +668,12 @@ Resources:
KeyType: HASH
- Attri... | E3002: Property IpAddresses should be of type List for resource
*cfn-lint version: cfn-lint 0.25.2*
When I use "conditional !If" inside "IpAddresses" properties of "AWS::Route53Resolver::ResolverEndpoint" I get error E3002.
```bash
cfn-lint --info -t vpc-k8s.template
2019-11-22 10:03:57,241 - cfnlint - INFO - ... | Thanks for the details. Thought we had this covered but obviously not. I will take a look. | 2019-11-22T16:51:59Z | [] | [] |
aws-cloudformation/cfn-lint | 1,226 | aws-cloudformation__cfn-lint-1226 | [
"1222"
] | 6ff7d7693f6e5170a98a35a48495ad927d46695c | diff --git a/src/cfnlint/__init__.py b/src/cfnlint/__init__.py
--- a/src/cfnlint/__init__.py
+++ b/src/cfnlint/__init__.py
@@ -799,6 +799,7 @@ def get_object_without_conditions(self, obj):
]
"""
results = []
+
scenarios = self.get_conditions_scenarios_from_object([obj])
... | diff --git a/test/fixtures/templates/bad/functions/if.yaml b/test/fixtures/templates/bad/functions/if.yaml
--- a/test/fixtures/templates/bad/functions/if.yaml
+++ b/test/fixtures/templates/bad/functions/if.yaml
@@ -8,10 +8,22 @@ Parameters:
Type: String
Default: isDevelopment
Conditions:
- isProduction: !Eq... | Fn:If argument count not checked
*cfn-lint version:*
0.25.3
*Description of issue.*
cfn-lint does not currently appear to check the number of arguments passed to Fn::If, while there may be cases where this is not practical to check, eg where an existing list is passed.
I believe it would probably be possible to... | Agreed. Should be an easy thing to add. | 2019-11-26T03:52:11Z | [] | [] |
aws-cloudformation/cfn-lint | 1,227 | aws-cloudformation__cfn-lint-1227 | [
"1223"
] | 10fe59e3a78120c475b83056677cfd3140bc68a9 | diff --git a/src/cfnlint/rules/parameters/Configuration.py b/src/cfnlint/rules/parameters/Configuration.py
--- a/src/cfnlint/rules/parameters/Configuration.py
+++ b/src/cfnlint/rules/parameters/Configuration.py
@@ -28,6 +28,10 @@ class Configuration(CloudFormationLintRule):
'Type',
]
+ required_keys ... | diff --git a/test/unit/rules/parameters/test_configuration.py b/test/unit/rules/parameters/test_configuration.py
--- a/test/unit/rules/parameters/test_configuration.py
+++ b/test/unit/rules/parameters/test_configuration.py
@@ -20,4 +20,4 @@ def test_file_positive(self):
def test_file_negative(self):
"""... | Warning Check on Unused Parameter hides Error Check about Missing Parameter Type
*cfn-lint version: cfn-lint 0.25.3*
Parameters defined in a template, but not directly used, are not validated for missing attributes like `Type`.
For various reasons, we want to include parameters in our templates that are not used ... | 2019-11-26T04:10:10Z | [] | [] | |
aws-cloudformation/cfn-lint | 1,231 | aws-cloudformation__cfn-lint-1231 | [
"1230"
] | 35e3108de2b5e0adb285eebd3301dfb5b8ed3534 | diff --git a/src/cfnlint/rules/resources/updatepolicy/Configuration.py b/src/cfnlint/rules/resources/updatepolicy/Configuration.py
--- a/src/cfnlint/rules/resources/updatepolicy/Configuration.py
+++ b/src/cfnlint/rules/resources/updatepolicy/Configuration.py
@@ -91,6 +91,12 @@ class Configuration(CloudFormationLintRule... | diff --git a/test/fixtures/templates/bad/resources/updatepolicy/config.yaml b/test/fixtures/templates/bad/resources/updatepolicy/config.yaml
--- a/test/fixtures/templates/bad/resources/updatepolicy/config.yaml
+++ b/test/fixtures/templates/bad/resources/updatepolicy/config.yaml
@@ -25,7 +25,7 @@ Resources:
MinSi... | `EnableVersionUpgrade` Update Policy Not Recognized
*cfn-lint version: (`cfn-lint --version`)* 0.25.5
*Description of issue:*
cfn-lint does not understand `AWS::Elasticsearch::Domain`'s new `UpdatePolicy` of `EnableVersionUpgrade`. This key accepts a Boolean value.
> If `EnableVersionUpgrade` is set to true, y... | 2019-11-26T19:16:06Z | [] | [] | |
aws-cloudformation/cfn-lint | 1,256 | aws-cloudformation__cfn-lint-1256 | [
"1252"
] | 0ce9f8d207e6801f62802563fd668b28af92235d | diff --git a/src/cfnlint/rules/functions/SubNeeded.py b/src/cfnlint/rules/functions/SubNeeded.py
--- a/src/cfnlint/rules/functions/SubNeeded.py
+++ b/src/cfnlint/rules/functions/SubNeeded.py
@@ -98,6 +98,8 @@ def match(self, cfn):
# We want to search all of the paths to check if each one contains an 'Fn::Sub... | diff --git a/test/fixtures/templates/good/functions/sub_needed.yaml b/test/fixtures/templates/good/functions/sub_needed.yaml
--- a/test/fixtures/templates/good/functions/sub_needed.yaml
+++ b/test/fixtures/templates/good/functions/sub_needed.yaml
@@ -1,6 +1,9 @@
---
AWSTemplateFormatVersion: "2010-09-09"
Parameters:... | False positive: Sub is required if a variable is used in a string in parameter descriptions
*cfn-lint version: 0.26.0*
*Description of issue.*
Parameter descriptions fail E1029 if they contain text which looks like variable substitution:
e.g.
```yaml
MyContentBucket:
Description: "Bucket name for cont... | 2019-12-16T01:02:44Z | [] | [] | |
aws-cloudformation/cfn-lint | 1,301 | aws-cloudformation__cfn-lint-1301 | [
"1295"
] | ffd22836781ac595be44a092d09699dbb18a0041 | diff --git a/src/cfnlint/rules/parameters/Configuration.py b/src/cfnlint/rules/parameters/Configuration.py
--- a/src/cfnlint/rules/parameters/Configuration.py
+++ b/src/cfnlint/rules/parameters/Configuration.py
@@ -14,37 +14,120 @@ class Configuration(CloudFormationLintRule):
source_url = 'https://docs.aws.amazon.... | diff --git a/test/fixtures/templates/bad/parameters.yaml b/test/fixtures/templates/bad/parameters.yaml
deleted file mode 100644
--- a/test/fixtures/templates/bad/parameters.yaml
+++ /dev/null
@@ -1,22 +0,0 @@
----
-AWSTemplateFormatVersion: '2010-09-09'
-Parameters:
- myParameter:
- # Type not string
- Type: Not... | Template format error: Every AllowedValues member must be a list
cfn-lint 0.26.2
Checking .yaml file, block
```yaml
Parameters:
Env:
Type: "String"
Description: "Environment"
Default: "staging"
AllowedValues:
staging
mock
production
DEVOPS... | Should be an easy one to do. Thanks for submitting this. | 2020-01-11T13:20:28Z | [] | [] |
aws-cloudformation/cfn-lint | 1,305 | aws-cloudformation__cfn-lint-1305 | [
"1221"
] | 0757dc4c7ba108f47c19eb0917b0e6e37ee62d83 | diff --git a/src/cfnlint/helpers.py b/src/cfnlint/helpers.py
--- a/src/cfnlint/helpers.py
+++ b/src/cfnlint/helpers.py
@@ -106,6 +106,11 @@
'Fn::Join', 'Fn::Split', 'Fn::FindInMap', 'Fn::Select', 'Ref',
'Fn::If', 'Fn::Contains', 'Fn::Sub', 'Fn::Cidr']
+FUNCTIONS_MULTIPLE = ['Fn::GetAZs', 'Fn::Split']
+
+# F... | diff --git a/test/fixtures/templates/bad/outputs.yaml b/test/fixtures/templates/bad/outputs/configuration.yaml
similarity index 61%
rename from test/fixtures/templates/bad/outputs.yaml
rename to test/fixtures/templates/bad/outputs/configuration.yaml
--- a/test/fixtures/templates/bad/outputs.yaml
+++ b/test/fixtures/tem... | Intrinsic function names are not validated in Conditions or Outputs
*cfn-lint version:* 0.25.3
*Description of issue.*
It appears that cfn lint does not check the name of intrinsic functions used in either the Conditions or the Outputs section of the template.
Using "Fn::Of": / !Of instead of "Fn::Or": / !Or in... | Agreed. Let me work on something for this. Thanks for reporting it.
Half of this is done. Need to do this for outputs still. | 2020-01-13T02:40:29Z | [] | [] |
aws-cloudformation/cfn-lint | 1,375 | aws-cloudformation__cfn-lint-1375 | [
"1373"
] | 42c0cd89577a39e903e5ef8a337926cc7ff6822c | diff --git a/src/cfnlint/__init__.py b/src/cfnlint/__init__.py
--- a/src/cfnlint/__init__.py
+++ b/src/cfnlint/__init__.py
@@ -24,11 +24,14 @@
from cfnlint.rules import ParseError as _ParseError
from cfnlint.rules import TransformError as _TransformError
from cfnlint.rules import RuleError as _RuleError
+from cfnlin... | diff --git a/test/fixtures/templates/bad/resources/rds/aurora_autoscaling.yaml b/test/fixtures/templates/bad/resources/rds/aurora_autoscaling.yaml
--- a/test/fixtures/templates/bad/resources/rds/aurora_autoscaling.yaml
+++ b/test/fixtures/templates/bad/resources/rds/aurora_autoscaling.yaml
@@ -1,6 +1,15 @@
---
AWSTem... | E0002 during E3028: 'dict' object has no attribute 'get_safe'
*cfn-lint version: (0.28.1)*
```
> cfn-lint cloudformation_templates/lint_fail.yaml
E0002 Unknown exception while processing rule E3028: 'dict' object has no attribute 'get_safe'
cloudformation_templates/lint_fail.yaml:1:1
```
This did not occur on... | @iamed2 fix coming shortly | 2020-02-20T00:12:46Z | [] | [] |
aws-cloudformation/cfn-lint | 1,381 | aws-cloudformation__cfn-lint-1381 | [
"800"
] | 7cb12a5d9a24fd9a04ee2559d2011d9fb10ba7ac | diff --git a/src/cfnlint/rules/resources/properties/ValuePrimitiveType.py b/src/cfnlint/rules/resources/properties/ValuePrimitiveType.py
--- a/src/cfnlint/rules/resources/properties/ValuePrimitiveType.py
+++ b/src/cfnlint/rules/resources/properties/ValuePrimitiveType.py
@@ -84,7 +84,6 @@ def _value_check(self, value, p... | diff --git a/test/fixtures/templates/good/resources/properties/primitive_types.yaml b/test/fixtures/templates/good/resources/properties/primitive_types.yaml
--- a/test/fixtures/templates/good/resources/properties/primitive_types.yaml
+++ b/test/fixtures/templates/good/resources/properties/primitive_types.yaml
@@ -6,7 +... | E3012 "String" recommended for an external template parameter where type is "Number"
*cfn-lint version: 0.18.0*
I define some of my template with sub-templates and everything is packaged with that kind of command line
```
aws cloudformation package --template-file ./sources/template-source.yaml --s3-bucket my-buc... | this is an interesting question. So we don't pull the nested stack templates to check their parameter types. We use the CloudFormation Spec to determine correctness for this. The trick here is the Map types are Strings. I am debating if we should just disable that check for this scenario.
```
"Parameters": {
... | 2020-02-23T14:58:06Z | [] | [] |
aws-cloudformation/cfn-lint | 1,391 | aws-cloudformation__cfn-lint-1391 | [
"1386",
"1386"
] | 7099d54fcb17deca849fe1f8a6cdf75050d459f5 | diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -72,6 +72,8 @@ def get_version(filename):
'jsonschema~=3.0',
'pathlib2>=2.3.0;python_version<="3.4"',
'importlib_resources~=1.0.2;python_version<"3.7"',
+ 'networkx~=2.4;python_version>="3.5"',
+ 'networkx~=2.1;py... | diff --git a/test/fixtures/templates/bad/resources_circulary_dependency.yaml b/test/fixtures/templates/bad/resources_circular_dependency.yaml
similarity index 100%
rename from test/fixtures/templates/bad/resources_circulary_dependency.yaml
rename to test/fixtures/templates/bad/resources_circular_dependency.yaml
diff --... | Rule E3004 is not checking for DependsOn declarations
*cfn-lint version*: 0.8.2
*Description of issue.*
The following template has a circular dependency:
```yaml
Resources:
Resource:
Type: AWS::SNS::Topic
DependsOn: Resource2
Resource2:
Type: AWS::SNS::Topic
DependsOn: Resource
```
... | Yup, code and description in this file would need to be updated:
https://github.com/aws-cloudformation/cfn-python-lint/blob/35a1fa54e828ce5497683551e9c43b4b210b4227/src/cfnlint/rules/resources/CircularDependency.py#L13-L16
Couple other rules have examples grabbing [`DependsOn`](https://docs.aws.amazon.com/AWSClou... | 2020-02-29T07:21:00Z | [] | [] |
aws-cloudformation/cfn-lint | 1,402 | aws-cloudformation__cfn-lint-1402 | [
"1387"
] | c772bc0b1d7ace30e87097218d269fb6a9372ee1 | diff --git a/src/cfnlint/decode/__init__.py b/src/cfnlint/decode/__init__.py
--- a/src/cfnlint/decode/__init__.py
+++ b/src/cfnlint/decode/__init__.py
@@ -65,7 +65,16 @@ def decode(filename, ignore_bad_template):
json_err.match.filename = filename
matches = [json_err.match]
... | diff --git a/test/unit/module/maintenance/test_update_documentation.py b/test/unit/module/maintenance/test_update_documentation.py
--- a/test/unit/module/maintenance/test_update_documentation.py
+++ b/test/unit/module/maintenance/test_update_documentation.py
@@ -74,7 +74,7 @@ class TestRuleWarning(CloudFormationLintRul... | Linter Errors in YAML Parsing should be in linter Message
# Version
cfn-lint 0.28.2
# Description of issue.
YAML Parsing errors should be included in the `Message` field rather than the generic `Expecting Value` message for rule `E0000`. The error messages from the `ScannerError` is much more accurate and descript... | I also just encountered this issue. Makes finding the problem a real pain but thanks to your question I could just search for `\t`s. Thank you.
Yea we do a few extra parsing tries when we run into the `\t` issue. The result currently is a masked error message. Making a few changes that should bring back the origina... | 2020-03-06T18:36:59Z | [] | [] |
aws-cloudformation/cfn-lint | 1,405 | aws-cloudformation__cfn-lint-1405 | [
"1351"
] | c9d78f4e8a53e5357902734d9d00814da99ba7b9 | diff --git a/src/cfnlint/rules/resources/events/RuleScheduleExpression.py b/src/cfnlint/rules/resources/events/RuleScheduleExpression.py
--- a/src/cfnlint/rules/resources/events/RuleScheduleExpression.py
+++ b/src/cfnlint/rules/resources/events/RuleScheduleExpression.py
@@ -37,7 +37,8 @@ def check_rate(self, value, pat... | diff --git a/test/fixtures/templates/bad/resources/events/rule_schedule_expression.yaml b/test/fixtures/templates/bad/resources/events/rule_schedule_expression.yaml
--- a/test/fixtures/templates/bad/resources/events/rule_schedule_expression.yaml
+++ b/test/fixtures/templates/bad/resources/events/rule_schedule_expressio... | AWS::Events::Rule ScheduleExpression: "cron(* 1 * * * *)"
*cfn-lint version: (cfn-lint 0.27.5)*
*Description of issue.*
```
EventRule:
Type: "AWS::Events::Rule"
Properties:
ScheduleExpression: "cron(* 1 * * * *)"
State: "ENABLED"
Targets:
- Arn: !Ref Foo
Id:... | @jtheuer I can get `* 1 * * ? *` to work. Are you getting an error in this situation? I'm seeing this in the documentation.
```
You can't specify the Day-of-month and Day-of-week fields in the same cron expression.
If you specify a value (or a *) in one of the fields, you must use a ? (question mark) in the other.... | 2020-03-07T14:36:54Z | [] | [] |
aws-cloudformation/cfn-lint | 1,409 | aws-cloudformation__cfn-lint-1409 | [
"1395"
] | ec366bb242efa668c6844c06a2b8bc08501a720b | diff --git a/src/cfnlint/rules/resources/rds/AuroraDBInstanceProperties.py b/src/cfnlint/rules/resources/rds/AuroraDBInstanceProperties.py
new file mode 100644
--- /dev/null
+++ b/src/cfnlint/rules/resources/rds/AuroraDBInstanceProperties.py
@@ -0,0 +1,66 @@
+"""
+Copyright 2019 Amazon.com, Inc. or its affiliates. All ... | diff --git a/test/fixtures/templates/bad/resources/rds/aurora_dbinstance_properties.yaml b/test/fixtures/templates/bad/resources/rds/aurora_dbinstance_properties.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/bad/resources/rds/aurora_dbinstance_properties.yaml
@@ -0,0 +1,40 @@
+---
+AWSTemplateFo... | Check for AllocatedStorage when DBInstance engine is not Aurora
*cfn-lint version: (`cfn-lint --version`)* 0.28.2
*Using latest spec*
*Description of issue.*
`cfn-lint` does not currently warn/error when an `AWS::RDS::DBInstance` is missing the `AllocatedStorage` property. This property is required when using no... | 2020-03-09T14:14:09Z | [] | [] | |
aws-cloudformation/cfn-lint | 1,419 | aws-cloudformation__cfn-lint-1419 | [
"1415"
] | be3867c6d45862a155b3c35ba6b0690ad5cab6bb | diff --git a/src/cfnlint/rules/resources/properties/ValuePrimitiveType.py b/src/cfnlint/rules/resources/properties/ValuePrimitiveType.py
--- a/src/cfnlint/rules/resources/properties/ValuePrimitiveType.py
+++ b/src/cfnlint/rules/resources/properties/ValuePrimitiveType.py
@@ -18,6 +18,15 @@ class ValuePrimitiveType(Cloud... | diff --git a/test/unit/rules/resources/properties/test_value_primitive_type.py b/test/unit/rules/resources/properties/test_value_primitive_type.py
--- a/test/unit/rules/resources/properties/test_value_primitive_type.py
+++ b/test/unit/rules/resources/properties/test_value_primitive_type.py
@@ -63,33 +63,34 @@ def setUp... | Environment Variables as Integer on AWS SAM template
*cfn-lint version: 0.28.4*
*Description of issue.*
When using Integer as Envrironment Variable for Serverless (AWS SAM), we get an error saying it should be String.
E3012 Property Resources/MyResource/Properties/Environment/Variables/MAIL_PORT should be of typ... | Translated Template.
```
{
"Description": "My Lambda Repository",
"Resources": {
"MyLambda": {
"Properties": {
"Code": {
"S3Bucket": "bucket",
"S3Key": "value"
},
"Environment": {
"Variables": {
"MAIL_PORT": 587,
"... | 2020-03-14T15:32:01Z | [] | [] |
aws-cloudformation/cfn-lint | 1,441 | aws-cloudformation__cfn-lint-1441 | [
"1438"
] | 7126c66a16228964afb7b0e34affe55499ce5613 | diff --git a/src/cfnlint/rules/resources/rds/InstanceEngine.py b/src/cfnlint/rules/resources/rds/InstanceEngine.py
new file mode 100644
--- /dev/null
+++ b/src/cfnlint/rules/resources/rds/InstanceEngine.py
@@ -0,0 +1,57 @@
+"""
+Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+SPDX-License-Ident... | diff --git a/test/fixtures/templates/bad/resources/rds/instance_engine.yaml b/test/fixtures/templates/bad/resources/rds/instance_engine.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/bad/resources/rds/instance_engine.yaml
@@ -0,0 +1,20 @@
+---
+AWSTemplateFormatVersion: "2010-09-09"
+Parameters:
... | E3030 case sensitivity caused DB instance destruction!
*cfn-lint version: (`cfn-lint --version`)* 0.29.0
*Description of issue.*
E3030 told me that "Postgres" was not an allowed engine name, so I changed it to "postgres". This caused cloudformation to rebuild my database instance, aka complete data loss. Luckily ... | I think this is also a CloudFormation bug, in that it compares the strings in a case-sensitive manner, when RDS underneath compares them in a case-insensitive manner. If you could file a bug there too that would be great.
Doing some more testing now. For some reason we called out mysql with multiple spellings.
```
... | 2020-03-25T16:07:52Z | [] | [] |
aws-cloudformation/cfn-lint | 1,444 | aws-cloudformation__cfn-lint-1444 | [
"1443"
] | ac097e59421b1e96657a76fb088406af97be5766 | diff --git a/src/cfnlint/rules/functions/SubNeeded.py b/src/cfnlint/rules/functions/SubNeeded.py
--- a/src/cfnlint/rules/functions/SubNeeded.py
+++ b/src/cfnlint/rules/functions/SubNeeded.py
@@ -19,7 +19,7 @@ class SubNeeded(CloudFormationLintRule):
# Free-form text properties to exclude from this rule
# cont... | diff --git a/test/unit/rules/functions/test_sub_needed.py b/test/unit/rules/functions/test_sub_needed.py
--- a/test/unit/rules/functions/test_sub_needed.py
+++ b/test/unit/rules/functions/test_sub_needed.py
@@ -31,9 +31,9 @@ def test_template_config(self):
)
self.helper_file_rule_config(
... | Unexpected E1029 error
*cfn-lint version: (0.29.1)*
*Description of issue.*
After this version was released, I started getting an error when linting a template. This error specific to `BuildSpec` attributes for a `AWS::CodeBuild::Project` project.
E1029 Found an embedded parameter outside of an "Fn::Sub" ... | 2020-03-25T22:55:00Z | [] | [] | |
aws-cloudformation/cfn-lint | 1,462 | aws-cloudformation__cfn-lint-1462 | [
"1170"
] | 23c7fb5618bbb9a85c89cc6dda23765254e9cbfe | diff --git a/src/cfnlint/config.py b/src/cfnlint/config.py
--- a/src/cfnlint/config.py
+++ b/src/cfnlint/config.py
@@ -48,17 +48,25 @@ class ConfigFileArgs(object):
Parses .cfnlintrc in the Home and Project folder.
"""
file_args = {}
+ __user_config_file = None
+ __project_config_file = None
+ ... | diff --git a/test/unit/module/config/test_config_file_args.py b/test/unit/module/config/test_config_file_args.py
--- a/test/unit/module/config/test_config_file_args.py
+++ b/test/unit/module/config/test_config_file_args.py
@@ -26,22 +26,34 @@ def tearDown(self):
def test_config_parser_read_config(self):
... | Parameter to pick the location of .cfnlintrc
Requesting to add a parameter that allows a user to specify a path to a `.cfnlintrc` file. Right now those are only a few locations we look for a `.cfnlintrc` file. We would like to allow a user to specify that location.
| Hello! What's the status of this task? Is someone working on this?
Sorry @Jhonatangiraldo. I missed this. I was going to pick this up this week unless you would like to take it.
So digging this into today. The question I have is if a path is specified do we not look into any other .cfnlintrc files? Right now we lo... | 2020-04-08T01:56:20Z | [] | [] |
aws-cloudformation/cfn-lint | 1,483 | aws-cloudformation__cfn-lint-1483 | [
"1400"
] | 495da386b658627aefda9d49a252e24a8244ba4d | diff --git a/src/cfnlint/rules/resources/route53/RecordSetName.py b/src/cfnlint/rules/resources/route53/RecordSetName.py
new file mode 100644
--- /dev/null
+++ b/src/cfnlint/rules/resources/route53/RecordSetName.py
@@ -0,0 +1,59 @@
+"""
+Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+SPDX-License-I... | diff --git a/test/fixtures/templates/bad/resources/route53/recordset_name.yaml b/test/fixtures/templates/bad/resources/route53/recordset_name.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/bad/resources/route53/recordset_name.yaml
@@ -0,0 +1,43 @@
+AWSTemplateFormatVersion: 2010-09-09
+Conditions... | Check whether RecordSet name is valid
*cfn-lint version: 0.28.2*
*Description of issue.*
cfn-lint could check whether the name is valid for a given hosted zone. Specifically:
```
+ "FooBarDelegation": {
+ "Type": "AWS::Route53::RecordSet",
+ "Properties": {
+ "HostedZoneName": "bar.exam... | @viraptor few other things I'm curious on.
1. Looks like `HostedZoneName` needs to end with a trailing `.`
2. Name can end or not with a trailing dot. They are treated equally
Do I have that correct? | 2020-04-21T16:24:07Z | [] | [] |
aws-cloudformation/cfn-lint | 1,506 | aws-cloudformation__cfn-lint-1506 | [
"1368"
] | 77be715e16585f04c0743b0a831c4d2ebdb85b5b | diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -53,7 +53,8 @@ def get_version(filename):
'importlib_resources~=1.0.2;python_version=="3.4"',
'importlib_resources~=1.4;python_version<"3.7" and python_version!="3.4"',
'networkx~=2.4;python_version>="3.5"',
- 'networkx<... | diff --git a/test/unit/module/formatters/test_formatters.py b/test/unit/module/formatters/test_formatters.py
--- a/test/unit/module/formatters/test_formatters.py
+++ b/test/unit/module/formatters/test_formatters.py
@@ -3,6 +3,7 @@
SPDX-License-Identifier: MIT-0
"""
import json
+import xml.etree.ElementTree as ET
fr... | --format JUnit XML reporting file format
**Feature request**
Would be really handle if we can get some more formatting options for popular test frameworks, for example JUnit XML.
These frameworks integrate into many build pipeline technologies for an integrated test reporting.
As it stands cfn-python-lint runs... | I second this. Being able to ingest the linting results for display in a tool like Jenkins would be very useful, especially for review by non-developer cloud architects. Ant's JUnit XML schema is here for reference: https://github.com/windyroad/JUnit-Schema/blob/master/JUnit.xsd | 2020-05-01T07:56:56Z | [] | [] |
aws-cloudformation/cfn-lint | 1,562 | aws-cloudformation__cfn-lint-1562 | [
"1561"
] | ebc7cfb3d77548b94066028509a5bcaa27892645 | diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -45,7 +45,7 @@ def get_version(filename):
'pyyaml<=5.2;python_version=="3.4"',
'pyyaml;python_version!="3.4"',
'six~=1.11',
- 'aws-sam-translator>=1.23.0',
+ 'aws-sam-translator>=1.24.0',
'jsonpatch;pytho... | diff --git a/test/fixtures/templates/good/transform/step_function_local_definition.yaml b/test/fixtures/templates/good/transform/step_function_local_definition.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/good/transform/step_function_local_definition.yaml
@@ -0,0 +1,12 @@
+Transform: AWS::Serve... | AWS::Serverless::StateMachine.DefinitionUri support for local files
*cfn-lint version: 0.32.1*
*Description of issue.*
The recent release of SAM support for Step Functions has added the ability to use a non-S3 URL for the [`DefinitionUri`](https://docs.aws.amazon.com/serverless-application-model/latest/developerg... | 2020-06-02T15:22:33Z | [] | [] | |
aws-cloudformation/cfn-lint | 1,580 | aws-cloudformation__cfn-lint-1580 | [
"1133"
] | 05db6949c9b43599f1b5e398a35f05046f9cf857 | diff --git a/src/cfnlint/__main__.py b/src/cfnlint/__main__.py
--- a/src/cfnlint/__main__.py
+++ b/src/cfnlint/__main__.py
@@ -26,14 +26,16 @@ def main():
rules = None
for filename in filenames:
LOGGER.debug('Begin linting of file: %s', str(filename))
- (template, rules, templa... | diff --git a/test/integration/test_transform_ignore.py b/test/integration/test_transform_ignore.py
new file mode 100644
--- /dev/null
+++ b/test/integration/test_transform_ignore.py
@@ -0,0 +1,23 @@
+"""
+Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+SPDX-License-Identifier: MIT-0
+"""
+from test.... | Ignore-checks doesn't work for E000*
*cfn-lint version: 0.22.3
*Ignore Checks isn't working*
Template: https://gist.github.com/jeffmacdonald/cbbdd8cc3a049f89dfb4a17991ca1afa
I am getting the following error:
```
E0000 Expecting value
templates/ssh-jump-host.yaml:1:1
```
When I run `pipenv run cfn-lint... | Agreed some of the E0000-E0005 checks may not be properly skipped when being configured to ignore them. We'll have to add some logic in for some of these generic rules.
Is this still an issue? I'm trying to ignore a check on a specific resource which uses a Transform function. But it is not getting ignore when i use ... | 2020-06-11T01:36:51Z | [] | [] |
aws-cloudformation/cfn-lint | 1,620 | aws-cloudformation__cfn-lint-1620 | [
"1619"
] | 6f8d7d4e1664a6f6e56ae99593066fc593b11b66 | diff --git a/src/cfnlint/rules/resources/certificatemanager/DomainValidationOptions.py b/src/cfnlint/rules/resources/certificatemanager/DomainValidationOptions.py
--- a/src/cfnlint/rules/resources/certificatemanager/DomainValidationOptions.py
+++ b/src/cfnlint/rules/resources/certificatemanager/DomainValidationOptions.... | diff --git a/test/fixtures/templates/good/resources/certificatemanager/domain_validation_options.yaml b/test/fixtures/templates/good/resources/certificatemanager/domain_validation_options.yaml
--- a/test/fixtures/templates/good/resources/certificatemanager/domain_validation_options.yaml
+++ b/test/fixtures/templates/go... | E3503 does not match CloudFormation - requires ValidationDomain when CF does not want it
*cfn-lint version: (`cfn-lint --version`)*
cfn-lint 0.33.2
*Description of issue.*
I created an ACM certificate resource, and there were problems configuring the `DomainValidationOptions` block. If using DNS validation, th... | Agreed. Thanks for reporting. We will work on getting this fixed. | 2020-07-09T17:23:13Z | [] | [] |
aws-cloudformation/cfn-lint | 1,627 | aws-cloudformation__cfn-lint-1627 | [
"1625"
] | 170fe0c05cd38e6a20dc3fce2b78cd02291aca79 | diff --git a/src/cfnlint/rules/resources/NoEcho.py b/src/cfnlint/rules/resources/NoEcho.py
--- a/src/cfnlint/rules/resources/NoEcho.py
+++ b/src/cfnlint/rules/resources/NoEcho.py
@@ -2,6 +2,7 @@
Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
SPDX-License-Identifier: MIT-0
"""
+import six
from cf... | diff --git a/test/fixtures/results/quickstart/nist_application.json b/test/fixtures/results/quickstart/nist_application.json
--- a/test/fixtures/results/quickstart/nist_application.json
+++ b/test/fixtures/results/quickstart/nist_application.json
@@ -179,33 +179,6 @@
"Source": "https://aws.amazon.com/blogs... | False alarm from new W4002
*cfn-lint version: 0.34.0*
[Here](https://gist.github.com/schmiddy/44a779032a930995d22ee2722a18f163) is an example template which causes a false alarm like this:
```
$ cfn-lint /tmp/example.yml
W4002 As the resource "metadata" section contains reference to a "NoEcho" parameter DBUser... | 2020-07-16T19:05:37Z | [] | [] | |
aws-cloudformation/cfn-lint | 1,631 | aws-cloudformation__cfn-lint-1631 | [
"1630"
] | 961ec8f026c6b7774e83e6ca73ca5336f5c1c03a | diff --git a/src/cfnlint/rules/__init__.py b/src/cfnlint/rules/__init__.py
--- a/src/cfnlint/rules/__init__.py
+++ b/src/cfnlint/rules/__init__.py
@@ -7,6 +7,7 @@
from datetime import datetime
import importlib
import traceback
+import six
import cfnlint.helpers
from cfnlint.decode.node import TemplateAttributeErro... | diff --git a/test/fixtures/templates/bad/generic.yaml b/test/fixtures/templates/bad/generic.yaml
--- a/test/fixtures/templates/bad/generic.yaml
+++ b/test/fixtures/templates/bad/generic.yaml
@@ -7,10 +7,10 @@ Mappings:
runtime:
us-east-1:
production:
- - CidrIp: 0.0.0.0/0
- IpProtocol: tcp
- ... | cfn-lint cannot catch "Every Type member must be a string"
*cfn-lint version: (`cfn-lint --version`)*
```
cfn-lint 0.34.0
```
*aws-cli version: (`aws --version`)*
```
aws-cli/1.18.97 Python/3.8.3 Linux/4.15.0-111-generic botocore/1.16.26
```
*Description of issue.*
```
$ cat template.yml
AWSTemplateForma... | Agreed we should have this covered. I'll get that fixed. | 2020-07-22T18:31:48Z | [] | [] |
aws-cloudformation/cfn-lint | 1,640 | aws-cloudformation__cfn-lint-1640 | [
"1639"
] | 879c1cef00f6aa63b74177ea6809f8721f57351c | diff --git a/src/cfnlint/helpers.py b/src/cfnlint/helpers.py
--- a/src/cfnlint/helpers.py
+++ b/src/cfnlint/helpers.py
@@ -171,6 +171,64 @@
'AWS::Redshift::Cluster'
]
+VALID_PARAMETER_TYPES_SINGLE = [
+ 'AWS::EC2::AvailabilityZone::Name',
+ 'AWS::EC2::Image::Id',
+ 'AWS::EC2::Instance::Id',
+ 'AWS::... | diff --git a/test/fixtures/templates/bad/conditions/equals.yaml b/test/fixtures/templates/bad/conditions/equals.yaml
--- a/test/fixtures/templates/bad/conditions/equals.yaml
+++ b/test/fixtures/templates/bad/conditions/equals.yaml
@@ -1,9 +1,23 @@
---
AWSTemplateFormatVersion: "2010-09-09"
+Parameters:
+ Environment... | Cannot catch "Fn::Equals object requires a list of 2 string parameters"
*cfn-lint version: (`cfn-lint --version`)*
```
cfn-lint 0.34.1
```
*aws-cli version: (`aws --version`)*
```
aws-cli/1.18.97 Python/3.8.3 Linux/4.15.0-111-generic botocore/1.16.26
```
*Description of issue.*
```
$ cat template.yml
AWS... | 2020-08-04T17:42:46Z | [] | [] | |
aws-cloudformation/cfn-lint | 1,659 | aws-cloudformation__cfn-lint-1659 | [
"1658"
] | f440351e4c1b5daca4388216e162a190fe1d6da9 | diff --git a/src/cfnlint/rules/functions/GetAtt.py b/src/cfnlint/rules/functions/GetAtt.py
--- a/src/cfnlint/rules/functions/GetAtt.py
+++ b/src/cfnlint/rules/functions/GetAtt.py
@@ -80,6 +80,15 @@ def match(self, cfn):
if resname:
if resname in valid_getatts:
if resty... | diff --git a/test/fixtures/templates/bad/functions/getatt.yaml b/test/fixtures/templates/bad/functions/getatt.yaml
--- a/test/fixtures/templates/bad/functions/getatt.yaml
+++ b/test/fixtures/templates/bad/functions/getatt.yaml
@@ -45,7 +45,16 @@ Resources:
# Shouldn't raise an error when using a Ref for the at... | AWS::ServiceCatalog::CloudFormationProvisionedProduct.Outputs
In July 2020, support for retrieving the outputs of provisioned Service Catalog products [was added to CloudFormation](https://aws.amazon.com/blogs/mt/how-to-launch-secure-and-governed-aws-resources-with-aws-cloudformation-and-aws-service-catalog/).
Given... | Submitted this to the wrong issue. I'm looking into this now. | 2020-08-18T00:00:22Z | [] | [] |
aws-cloudformation/cfn-lint | 1,690 | aws-cloudformation__cfn-lint-1690 | [
"1688"
] | cf0f5b55bf471fc1e9021e28cbac54aef5bf8821 | diff --git a/src/cfnlint/rules/resources/codepipeline/CodepipelineStageActions.py b/src/cfnlint/rules/resources/codepipeline/CodepipelineStageActions.py
--- a/src/cfnlint/rules/resources/codepipeline/CodepipelineStageActions.py
+++ b/src/cfnlint/rules/resources/codepipeline/CodepipelineStageActions.py
@@ -220,6 +220,35... | diff --git a/test/fixtures/templates/bad/resources/codepipeline/action_artifact_counts.yaml b/test/fixtures/templates/bad/resources/codepipeline/action_artifact_counts.yaml
--- a/test/fixtures/templates/bad/resources/codepipeline/action_artifact_counts.yaml
+++ b/test/fixtures/templates/bad/resources/codepipeline/actio... | Doesn't catch CodePipeline OutputArtifacts need to be uniquely named
cfn-lint 0.35.1
*Description of issue.*
The linter doesn't catch that CodePipeline `OutputArtifacts` need to be uniquely named.
Please provide as much information as possible:
* Template linting issues:
* Please provide a CloudFormation sa... | 2020-09-11T15:16:38Z | [] | [] | |
aws-cloudformation/cfn-lint | 1,714 | aws-cloudformation__cfn-lint-1714 | [
"1713"
] | ad22c9a1c6cd20853ec91db4bcd1808ebbaad4e3 | diff --git a/src/cfnlint/rules/__init__.py b/src/cfnlint/rules/__init__.py
--- a/src/cfnlint/rules/__init__.py
+++ b/src/cfnlint/rules/__init__.py
@@ -232,12 +232,30 @@ def resource_property(self, filename, cfn, path, properties, resource_type, prop
if property_spec_name in property_spec:
for ru... | diff --git a/test/fixtures/templates/good/resource_properties.yaml b/test/fixtures/templates/good/resource_properties.yaml
--- a/test/fixtures/templates/good/resource_properties.yaml
+++ b/test/fixtures/templates/good/resource_properties.yaml
@@ -312,6 +312,7 @@ Parameters:
Type: "CommaDelimitedList"
Default:... | Using If Condition for AWS::S3::Bucket ReplicationConfiguration property
*cfn-lint version: (`cfn-lint --version`)*
cfn-lint 0.34.0
```
E3002 Expecting an object at Resources/CloudAvailS3Bucket/Properties/ReplicationConfiguration/Fn::If/1
devops/infra/cloudavail.yaml:146:11
E3002 Expecting an object at Resources... | 2020-09-24T16:52:24Z | [] | [] | |
aws-cloudformation/cfn-lint | 1,750 | aws-cloudformation__cfn-lint-1750 | [
"1084"
] | b7815fed1bc6ffc255bff816d8b884fec67b5f11 | diff --git a/src/cfnlint/helpers.py b/src/cfnlint/helpers.py
--- a/src/cfnlint/helpers.py
+++ b/src/cfnlint/helpers.py
@@ -79,34 +79,6 @@
REGEX_DYN_REF_SSM_SECURE = re.compile(r'^.*{{resolve:ssm-secure:[a-zA-Z0-9_\.\-/]+:\d+}}.*$')
-AVAILABILITY_ZONES = [
- 'af-south-1a', 'af-south-1b', 'af-south-1c',
- 'ap-... | diff --git a/test/fixtures/results/quickstart/nist_application.json b/test/fixtures/results/quickstart/nist_application.json
--- a/test/fixtures/results/quickstart/nist_application.json
+++ b/test/fixtures/results/quickstart/nist_application.json
@@ -78,56 +78,6 @@
"Source": "https://docs.aws.amazon.com/AW... | extend CIDR regex validation
Rules [`W2509`](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/src/cfnlint/rules/parameters/Cidr.py) and [`E2004`](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/src/cfnlint/rules/parameters/CidrAllowedValues.py) check CIDR parameters have `AllowedPatte... | 2020-10-22T23:13:28Z | [] | [] | |
aws-cloudformation/cfn-lint | 1,767 | aws-cloudformation__cfn-lint-1767 | [
"1743"
] | 3c2165a65b8deba5731067a060636913f2784540 | diff --git a/src/cfnlint/rules/resources/lmbd/EventsLogGroupName.py b/src/cfnlint/rules/resources/lmbd/EventsLogGroupName.py
--- a/src/cfnlint/rules/resources/lmbd/EventsLogGroupName.py
+++ b/src/cfnlint/rules/resources/lmbd/EventsLogGroupName.py
@@ -2,6 +2,7 @@
Copyright Amazon.com, Inc. or its affiliates. All Rights... | diff --git a/test/fixtures/templates/bad/some_logs_stream_lambda.yaml b/test/fixtures/templates/bad/some_logs_stream_lambda.yaml
--- a/test/fixtures/templates/bad/some_logs_stream_lambda.yaml
+++ b/test/fixtures/templates/bad/some_logs_stream_lambda.yaml
@@ -70,6 +70,11 @@ Resources:
Properties:
... | E2529 error with multiple `AWS::Logs::SubscriptionFilter` resources.
*cfn-lint version: 0.38.0*
*[`E2529`](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2529) error with multiple [`AWS::Logs::SubscriptionFilter`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-re... | Few things here.
- `aws cloudformation validate-template` isn't detailed enough to catch this error. I'm assuming this template deploys correctly? That is the most important thing.
- It looks like the limit for Subscription Filters has increased to 2 from 1. See [current docs](https://docs.aws.amazon.com/AmazonClou... | 2020-11-05T14:59:58Z | [] | [] |
aws-cloudformation/cfn-lint | 1,773 | aws-cloudformation__cfn-lint-1773 | [
"1766"
] | 4ef277bb637c533582c2b10d3589b4aa3623f3bf | diff --git a/src/cfnlint/rules/resources/properties/Properties.py b/src/cfnlint/rules/resources/properties/Properties.py
--- a/src/cfnlint/rules/resources/properties/Properties.py
+++ b/src/cfnlint/rules/resources/properties/Properties.py
@@ -23,6 +23,7 @@ def __init__(self):
self.resourcetypes = {}
s... | diff --git a/test/fixtures/templates/bad/resource_properties.yaml b/test/fixtures/templates/bad/resource_properties.yaml
--- a/test/fixtures/templates/bad/resource_properties.yaml
+++ b/test/fixtures/templates/bad/resource_properties.yaml
@@ -35,3 +35,16 @@ Resources:
UserData: !Ref AWS::NotificationARNs
... | Using ImportValue skips List type resource validation
*cfn-lint version: (`cfn-lint --version`)*
cfn-lint 0.40.0
*Description of issue.*
When we use [`Fn::ImportValue`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-importvalue.html) for a resource key that needs type L... | 2020-11-06T00:15:22Z | [] | [] | |
aws-cloudformation/cfn-lint | 1,774 | aws-cloudformation__cfn-lint-1774 | [
"1772"
] | 34f34e4d9a565be5c68abeefc42fcf9505f5c30c | diff --git a/src/cfnlint/rules/functions/Sub.py b/src/cfnlint/rules/functions/Sub.py
--- a/src/cfnlint/rules/functions/Sub.py
+++ b/src/cfnlint/rules/functions/Sub.py
@@ -85,8 +85,8 @@ def _test_parameters(self, parameters, cfn, tree):
message = 'Sub parameter should be an object of 1 for {0}'
... | diff --git a/test/fixtures/templates/bad/functions/sub.yaml b/test/fixtures/templates/bad/functions/sub.yaml
--- a/test/fixtures/templates/bad/functions/sub.yaml
+++ b/test/fixtures/templates/bad/functions/sub.yaml
@@ -54,8 +54,10 @@ Resources:
Properties:
CidrBlock:
Fn::Sub:
- - "${myCidr}"... | Incorrect rule: "E1019: Sub parameter should be an object of 1 or string for..."
*cfn-lint version: 0.40.0*
I am getting an incorrect error that [`E1019`](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1019)` Sub parameter should be an object of 1 or string for...` when using YAML:
... | Haven't looked into this yet, but getting thrown here:
https://github.com/aws-cloudformation/cfn-python-lint/blob/4ef277bb637c533582c2b10d3589b4aa3623f3bf/src/cfnlint/rules/functions/Sub.py#L88-L91 | 2020-11-06T16:51:48Z | [] | [] |
aws-cloudformation/cfn-lint | 1,788 | aws-cloudformation__cfn-lint-1788 | [
"1662",
"1662"
] | ac5627f267393d573d2b130f1607fbac1f7f1c7d | diff --git a/src/cfnlint/rules/functions/SubNeeded.py b/src/cfnlint/rules/functions/SubNeeded.py
--- a/src/cfnlint/rules/functions/SubNeeded.py
+++ b/src/cfnlint/rules/functions/SubNeeded.py
@@ -2,57 +2,36 @@
Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
SPDX-License-Identifier: MIT-0
"""
-from ... | diff --git a/test/fixtures/schemas/SubNeededExcludes.json b/test/fixtures/schemas/SubNeededExcludes.json
new file mode 100644
--- /dev/null
+++ b/test/fixtures/schemas/SubNeededExcludes.json
@@ -0,0 +1,66 @@
+{
+ "$schema": "http://json-schema.org/draft-04/schema#",
+ "title": "Product",
+ "description": "Excl... | E1029 - False positive with multiline YAML string
*cfn-lint version: (`cfn-lint --version`)*
0.35.0
*Description of issue.*
Using ${iot:Connection.Thing.ThingName} inside an AWS::IoT::Policy PolicyDocument is flagged as an embedded parameter outside of Fn::Sub.
Freshly installed cfn-lint this morning. I'm using... | **Seems like the [multiline YAML string](https://yaml-multiline.info/) isn't handled by this:**
https://github.com/aws-cloudformation/cfn-python-lint/blob/766f47072f8b93f13be3129a59c06e5cee5f2bc3/src/cfnlint/rules/functions/SubNeeded.py#L33-L38
https://github.com/aws-cloudformation/cfn-python-lint/blob/766f47072f... | 2020-11-18T14:33:03Z | [] | [] |
aws-cloudformation/cfn-lint | 1,900 | aws-cloudformation__cfn-lint-1900 | [
"1868"
] | b20e59a9a2538f62b77f3821d19cdeccc977e689 | diff --git a/src/cfnlint/decode/__init__.py b/src/cfnlint/decode/__init__.py
--- a/src/cfnlint/decode/__init__.py
+++ b/src/cfnlint/decode/__init__.py
@@ -51,8 +51,7 @@ def decode(filename):
matches.append(create_match_file_error(
filename, 'Cannot read file contents: %s' % filename))
except ... | diff --git a/test/unit/module/test_duplicate.py b/test/unit/module/test_duplicate.py
--- a/test/unit/module/test_duplicate.py
+++ b/test/unit/module/test_duplicate.py
@@ -44,8 +44,8 @@ def test_fail_run(self):
try:
with open(filename) as fp:
json.load(fp, cls=cfnlint.decode.cfn_js... | Only the first Resource Duplicate is found - E0000
*cfn-lint version: (`cfn-lint 0.44.3`)*
*Description of issue.*
I get the error `E0000 Duplicate resource found "DevRouteTableRoute2" (line 18)` when I try to validate a CFn template with duplicated resources. I should get has many errors has the number of duplic... | 2021-02-12T20:58:21Z | [] | [] | |
aws-cloudformation/cfn-lint | 1,915 | aws-cloudformation__cfn-lint-1915 | [
"1193"
] | 8580cae93ab9218455fd7eebeb719dc16146a02b | diff --git a/src/cfnlint/config.py b/src/cfnlint/config.py
--- a/src/cfnlint/config.py
+++ b/src/cfnlint/config.py
@@ -425,6 +425,10 @@ def __call__(self, parser, namespace, values, option_string=None):
'--output-file', type=str, default=None,
help='Writes the output to the specified file, ide... | diff --git a/test/unit/module/config/test_config_mixin.py b/test/unit/module/config/test_config_mixin.py
--- a/test/unit/module/config/test_config_mixin.py
+++ b/test/unit/module/config/test_config_mixin.py
@@ -159,3 +159,29 @@ def test_config_expand_ignore_templates(self, yaml_mock):
self.assertNotIn(
... | Use of -i IGNORE_CHECKS conflicts with Metadata ignore_checks
*cfn-lint version: 0.25.0
*Description of issue.*
When specifying -i <CHECK> on the command line cfn-lint no longer honours ignore_checks metadata in the template (at last for template level metadata).
*Background*
The recently introduced I1022 rule ... | The way it works today is that things are overrode and not merged. So adding `-i I1022` will override ignore checks in .cfnlintrc and any template level Metadata ignore checks. We could work on a way to merge those settings instead of overriding. At least for the list based settings.
Were you able to investigate... | 2021-02-22T18:42:57Z | [] | [] |
aws-cloudformation/cfn-lint | 1,952 | aws-cloudformation__cfn-lint-1952 | [
"1951"
] | a8853c866d16a2258828f680b23842f3175fe513 | diff --git a/src/cfnlint/maintenance.py b/src/cfnlint/maintenance.py
--- a/src/cfnlint/maintenance.py
+++ b/src/cfnlint/maintenance.py
@@ -234,7 +234,10 @@ def update_iam_policies():
content = content.split('app.PolicyEditorConfig=')[1]
content = json.loads(content)
- content['serviceMap']['Manage Amazon... | diff --git a/test/unit/module/maintenance/test_update_iam_policies.py b/test/unit/module/maintenance/test_update_iam_policies.py
--- a/test/unit/module/maintenance/test_update_iam_policies.py
+++ b/test/unit/module/maintenance/test_update_iam_policies.py
@@ -19,7 +19,7 @@ class TestUpdateIamPolicies(BaseTestCase):
... | "Manage Amazon API Gateway" key cannot be found when running with flag --update-iam-policies
*cfn-lint version: (`cfn-lint --version`)* 0.48.0
*Description of issue.*
Running the commands:
```
pip install cfn-lint
cfn-lint --update-specs
cfn-lint --update-iam-policies
```
in an empty Python 3.8 Docker c... | I'll take a look. Thanks for reporting this. | 2021-03-23T18:32:44Z | [] | [] |
aws-cloudformation/cfn-lint | 1,978 | aws-cloudformation__cfn-lint-1978 | [
"1977"
] | 73dc3d505ecdb085b7f1684f8711592082cafef3 | diff --git a/src/cfnlint/rules/resources/ectwo/Ebs.py b/src/cfnlint/rules/resources/ectwo/Ebs.py
--- a/src/cfnlint/rules/resources/ectwo/Ebs.py
+++ b/src/cfnlint/rules/resources/ectwo/Ebs.py
@@ -9,10 +9,10 @@
class Ebs(CloudFormationLintRule):
- """Check if Ec2 Ebs Resource Properties"""
+ """Check Ec2 Ebs R... | diff --git a/test/fixtures/templates/good/resources/ec2/ebs.yaml b/test/fixtures/templates/good/resources/ec2/ebs.yaml
--- a/test/fixtures/templates/good/resources/ec2/ebs.yaml
+++ b/test/fixtures/templates/good/resources/ec2/ebs.yaml
@@ -46,6 +46,12 @@ Resources:
DeleteOnTermination: false
Vo... | E2504 incorrectly rejects "Iops" property for io2/gp3 volumes
*cfn-lint version: (`cfn-lint --version`)*
cfn-lint 0.44.6
*Description of issue.*
cfn-lint produces an error "E2504: Iops shouldn't be defined for type io2 for Resource ... LaunchConfiguration/Properties/BlockDeviceMappings/0/Ebs/Iops" when setting... | 2021-04-12T05:44:53Z | [] | [] | |
aws-cloudformation/cfn-lint | 1,989 | aws-cloudformation__cfn-lint-1989 | [
"1987"
] | c8f6c3e42dff492e167b3df10c39cbbe4d58ca82 | diff --git a/src/cfnlint/rules/functions/RelationshipConditions.py b/src/cfnlint/rules/functions/RelationshipConditions.py
--- a/src/cfnlint/rules/functions/RelationshipConditions.py
+++ b/src/cfnlint/rules/functions/RelationshipConditions.py
@@ -24,7 +24,7 @@ def match(self, cfn):
matches = []
# St... | diff --git a/test/fixtures/templates/good/functions/relationship_conditions_sam.yaml b/test/fixtures/templates/good/functions/relationship_conditions_sam.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/good/functions/relationship_conditions_sam.yaml
@@ -0,0 +1,37 @@
+---
+AWSTemplateFormatVersion:... | SAM Function Global Environment Variables Interact Oddly with `!If` and Conditional Values
*cfn-lint version: (`cfn-lint --version`)*
cfn-lint 0.46.0
*Description of issue.*
When the `!If` intrinsic function is used with conditional values in SAM's Global Environment Variables, cfn-lint warns that the value on... | Mapping from the violation in the transformed template back to the line in the original source template is a bit best effort
Still looking into the violation itself though
I think that it's because [Line 933 in template.py][key] is key-not-found'ing on `text[path[0]]`. At that time, `path[0]` is "Function", which is... | 2021-04-22T16:29:01Z | [] | [] |
aws-cloudformation/cfn-lint | 2,006 | aws-cloudformation__cfn-lint-2006 | [
"2004"
] | 490e75c69cb9a7290f4ed25174d7f5c47a0ba986 | diff --git a/src/cfnlint/rules/mappings/KeyName.py b/src/cfnlint/rules/mappings/KeyName.py
--- a/src/cfnlint/rules/mappings/KeyName.py
+++ b/src/cfnlint/rules/mappings/KeyName.py
@@ -17,14 +17,26 @@ class KeyName(CloudFormationLintRule):
source_url = 'https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/... | diff --git a/test/fixtures/templates/bad/mappings/key_name.yaml b/test/fixtures/templates/bad/mappings/key_name.yaml
--- a/test/fixtures/templates/bad/mappings/key_name.yaml
+++ b/test/fixtures/templates/bad/mappings/key_name.yaml
@@ -7,4 +7,8 @@ Mappings:
us-east-1a:
123456789012: "ami-951945d0"
us-... | cfn-lint 0.49.1 does not catch `/` as an invalid character in a Mapping element name
*cfn-lint version: cfn-lint 0.49.1*
*cfn-lint did not catch `/` as an invalid character in a Mapping element name*
cfn-lint passed successfully with this mapping included in the template:
```yaml
Mappings:
NameServers:
... | Thanks for reporting, does seem to be missing that level:
<img width="656" alt="Screen Shot 2021-05-11 at 9 49 34 PM" src="https://user-images.githubusercontent.com/7014355/117906384-ce44e600-b2a2-11eb-9ad7-1d900c5ec4bd.png">
@PatMyron According to the [documentation](https://docs.aws.amazon.com/AWSCloudFormation/... | 2021-05-12T16:08:08Z | [] | [] |
aws-cloudformation/cfn-lint | 2,017 | aws-cloudformation__cfn-lint-2017 | [
"2016"
] | 854471346e368e46e4097fa35867cfcda44269f8 | diff --git a/src/cfnlint/rules/mappings/KeyName.py b/src/cfnlint/rules/mappings/KeyName.py
--- a/src/cfnlint/rules/mappings/KeyName.py
+++ b/src/cfnlint/rules/mappings/KeyName.py
@@ -35,7 +35,7 @@ def check_key(self, key, path):
if not isinstance(key, six.string_types):
message = 'Mapping key ({0}... | diff --git a/test/fixtures/templates/good/mappings/key_name.yaml b/test/fixtures/templates/good/mappings/key_name.yaml
--- a/test/fixtures/templates/good/mappings/key_name.yaml
+++ b/test/fixtures/templates/good/mappings/key_name.yaml
@@ -1,5 +1,10 @@
AWSTemplateFormatVersion: "2010-09-09"
Mappings:
+ AwsAgentPlatfo... | E7003 Errors when using Fn::Transform inside a Mapping
*cfn-lint version: 0.49.2*
*Description of issue.*
#2006 tightened what is considered valid for use in a Mapping. This causes it to reject what otherwise appears to be a valid use of `Fn::Transform` as the body of a Mapping.
For example, this snippet is val... | see https://github.com/aws-cloudformation/cfn-lint/issues/2014, planning on continuing to track this in https://github.com/aws-cloudformation/cfn-lint/issues/476 | 2021-05-21T16:28:52Z | [] | [] |
aws-cloudformation/cfn-lint | 2,023 | aws-cloudformation__cfn-lint-2023 | [
"2021"
] | 14d5d416e1172563f3453e977cf3d711bf61c7dc | diff --git a/src/cfnlint/rules/resources/iam/Policy.py b/src/cfnlint/rules/resources/iam/Policy.py
--- a/src/cfnlint/rules/resources/iam/Policy.py
+++ b/src/cfnlint/rules/resources/iam/Policy.py
@@ -5,7 +5,7 @@
import json
from datetime import date
import six
-from cfnlint.helpers import convert_dict
+from cfnlint.h... | diff --git a/test/fixtures/templates/bad/properties_iam_policy.yaml b/test/fixtures/templates/bad/resources/iam/iam_policy.yaml
similarity index 77%
rename from test/fixtures/templates/bad/properties_iam_policy.yaml
rename to test/fixtures/templates/bad/resources/iam/iam_policy.yaml
--- a/test/fixtures/templates/bad/pr... | Linter does not catch MalformedPolicyDocument syntax error
*cfn-lint version: 0.25.0*
*Description of issue.*
`cfn-lint` fails to catch the following syntax error pre-deployment, which is caught by CloudFormation during deployment:
```
Syntax errors in policy. (Service: AmazonIdentityManagement; Status Code: 400;... | To clarify, is the syntax error for this template just the indentation? | 2021-05-26T22:14:54Z | [] | [] |
aws-cloudformation/cfn-lint | 2,031 | aws-cloudformation__cfn-lint-2031 | [
"2026"
] | 3d30463ec1cf3eca5141230729ab33070aa7b753 | diff --git a/src/cfnlint/rules/functions/SubNeeded.py b/src/cfnlint/rules/functions/SubNeeded.py
--- a/src/cfnlint/rules/functions/SubNeeded.py
+++ b/src/cfnlint/rules/functions/SubNeeded.py
@@ -4,6 +4,7 @@
"""
from functools import reduce # pylint: disable=redefined-builtin
import re
+import copy
import six
from... | diff --git a/test/fixtures/templates/good/functions/sub_needed_custom_excludes.yaml b/test/fixtures/templates/good/functions/sub_needed_custom_excludes.yaml
--- a/test/fixtures/templates/good/functions/sub_needed_custom_excludes.yaml
+++ b/test/fixtures/templates/good/functions/sub_needed_custom_excludes.yaml
@@ -1,10 ... | E1029 - false positive with X.509 Certificate AWS IoT Core policy variables
cfn-lint version: (cfn-lint 0.49.2)
I got a false positive on X.509 Certificate AWS IoT Core policy variables.
I think that `cfn-lint` may not support X.509 Certificate AWS IoT Core policy variables.
https://docs.aws.amazon.com/iot/lat... | @xeres when I use this template to create a stack i get `Template error: instance of Fn::Sub references invalid resource attribute iot:Certificate.Subject.CommonName` which is similar to the error we provide.
You will want to make sure you use the literal string like this `!Sub "arn:aws:iot:us-east-1:123456789012:to... | 2021-06-02T16:31:57Z | [] | [] |
aws-cloudformation/cfn-lint | 2,140 | aws-cloudformation__cfn-lint-2140 | [
"2139"
] | 0c5d63e0f681fde3c385514c08aefb9aac13fbaa | diff --git a/src/cfnlint/rules/functions/Cidr.py b/src/cfnlint/rules/functions/Cidr.py
--- a/src/cfnlint/rules/functions/Cidr.py
+++ b/src/cfnlint/rules/functions/Cidr.py
@@ -18,6 +18,91 @@ class Cidr(CloudFormationLintRule):
source_url = 'https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-fu... | diff --git a/test/fixtures/templates/bad/functions_cidr.yaml b/test/fixtures/templates/bad/functions_cidr.yaml
--- a/test/fixtures/templates/bad/functions_cidr.yaml
+++ b/test/fixtures/templates/bad/functions_cidr.yaml
@@ -1,58 +1,106 @@
AWSTemplateFormatVersion: 2010-09-09
Parameters:
- cidrBlock :
- Type:... | E1024 Fn::Cidr should allow Fn::If that returns valid types
*cfn-lint version: (`0.52.0+`)*
*Description of issue.*
We cut down Subnets from the VPC CIDR by scoping down CIDRs in increasing sizes and using the `Fn::Cidr` function with select to pick the appropriate subnet.
Currently, it looks like `E1024` allo... | 2021-10-14T16:33:21Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,208 | aws-cloudformation__cfn-lint-2208 | [
"2189"
] | d68125b644cd09a3bdb0040e4e1040e1a2bdad9a | diff --git a/src/cfnlint/rules/custom/Operators.py b/src/cfnlint/rules/custom/Operators.py
--- a/src/cfnlint/rules/custom/Operators.py
+++ b/src/cfnlint/rules/custom/Operators.py
@@ -49,7 +49,7 @@ def _check_value(self, value, path, property_chain, cfn):
cfn=cfn,
))
... | diff --git a/test/fixtures/custom_rules/bad/custom_rule_invalid_boolean.txt b/test/fixtures/custom_rules/bad/custom_rule_invalid_boolean.txt
new file mode 100644
--- /dev/null
+++ b/test/fixtures/custom_rules/bad/custom_rule_invalid_boolean.txt
@@ -0,0 +1 @@
+AWS::EC2::Instance BlockDeviceMappings.Ebs.DeleteOnTerminati... | Custom Rule not working for boolean values
*cfn-lint version: (`cfn-lint --version`)* 0.54.4
*Description of issue.* Attempting to create a custom rule to detect KMS keys that do not have auto rotate enabled. I discovered https://github.com/aws-cloudformation/cfn-lint/issues/2185 which covers the inability to react ... | 2022-01-28T22:07:06Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,226 | aws-cloudformation__cfn-lint-2226 | [
"2224"
] | b95629a833270f87e16acf99674e53b339b588ff | diff --git a/src/cfnlint/decode/cfn_yaml.py b/src/cfnlint/decode/cfn_yaml.py
--- a/src/cfnlint/decode/cfn_yaml.py
+++ b/src/cfnlint/decode/cfn_yaml.py
@@ -103,7 +103,21 @@ def construct_yaml_map(self, node):
),
]
)
- mapping[key] = va... | diff --git a/test/fixtures/templates/bad/core/parse_invalid_map.yaml b/test/fixtures/templates/bad/core/parse_invalid_map.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/bad/core/parse_invalid_map.yaml
@@ -0,0 +1,23 @@
+Resources:
+ NodeGroup:
+ Type: "AWS::AutoScaling::AutoScalingGroup"
+ ... | construct_yaml_map leading to TypeError: unhashable type: 'dict_node'
*cfn-lint version: 0.58.1*
*Unhandled `TypeError: unhashable type: 'dict_node'` thrown from construct_yaml_map.*
Please provide as much information as possible:
Utilising some slightly edited form of the example eks-nodegroup cfn, [see here fo... | Looking into it. | 2022-02-28T20:18:08Z | [] | [] |
aws-cloudformation/cfn-lint | 2,230 | aws-cloudformation__cfn-lint-2230 | [
"2229"
] | 40b87cc41e76b8ce04c0089643df5b510e468ee1 | diff --git a/src/cfnlint/rules/resources/backup/BackupPlanLifecycleRule.py b/src/cfnlint/rules/resources/backup/BackupPlanLifecycleRule.py
new file mode 100644
--- /dev/null
+++ b/src/cfnlint/rules/resources/backup/BackupPlanLifecycleRule.py
@@ -0,0 +1,31 @@
+"""
+Copyright Amazon.com, Inc. or its affiliates. All Right... | diff --git a/test/fixtures/templates/bad/resources/backup/test_backup_plan_lifecycle_rule.yml b/test/fixtures/templates/bad/resources/backup/test_backup_plan_lifecycle_rule.yml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/bad/resources/backup/test_backup_plan_lifecycle_rule.yml
@@ -0,0 +1,17 @@
+---... | [New Rule] BackupPlan Lifecycle cold to delete minimum difference
*cfn-lint version:* 0.58.2
*Description of issue.*
In CloudFormation, when deploying a stack with an `AWS::Backup::BackupPlan` lifecycle rule to age off data after moving it to cold storage, the deployment will fail if the `DeleteAfterDays` value is ... | 2022-03-04T23:00:21Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,236 | aws-cloudformation__cfn-lint-2236 | [
"1828"
] | d8e87268175fff335f31d7173354e54e3f28cc68 | diff --git a/src/cfnlint/transform.py b/src/cfnlint/transform.py
--- a/src/cfnlint/transform.py
+++ b/src/cfnlint/transform.py
@@ -76,7 +76,10 @@ def _replace_local_codeuri(self):
if resource_type == 'AWS::Serverless::Function':
- Transform._update_to_s3_uri('CodeUri', resource_dict)
+ ... | diff --git a/test/fixtures/templates/good/transform/function_using_image.yaml b/test/fixtures/templates/good/transform/function_using_image.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/good/transform/function_using_image.yaml
@@ -0,0 +1,11 @@
+AWSTemplateFormatVersion: '2010-09-09'
+Transform: ... | Support for the docker lambda runtime
cfn-lint 0.43.0
This is a feature request for supporting docker lambda sam templates.
Please provide as much information as possible:
* SAM templates produced by aws-sam-cli with the docker deploy option don't pass validation
Running on the template.yaml in the base direc... | could you include your template?
The second half likely involves https://github.com/aws-cloudformation/cfn-python-lint/issues/1219 since no [Resource Specfications](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-resource-specification.html) have been released for weeks
The first half may be fi... | 2022-03-18T15:43:04Z | [] | [] |
aws-cloudformation/cfn-lint | 2,242 | aws-cloudformation__cfn-lint-2242 | [
"1657"
] | 695055f5a7d7555e07729392a60aa26458cad9c3 | diff --git a/src/cfnlint/config.py b/src/cfnlint/config.py
--- a/src/cfnlint/config.py
+++ b/src/cfnlint/config.py
@@ -443,34 +443,36 @@ def get_template_args(self):
def set_template_args(self, template):
defaults = {}
if isinstance(template, dict):
- configs = template.get('Metadata',... | diff --git a/test/fixtures/templates/bad/conditions.yaml b/test/fixtures/templates/bad/conditions.yaml
--- a/test/fixtures/templates/bad/conditions.yaml
+++ b/test/fixtures/templates/bad/conditions.yaml
@@ -48,6 +48,7 @@ Conditions:
"Fn::Of":
- !Not [!Equals [!Ref EnvType, ""]]
- !Not [!Equals [!Ref ... | Using null in AWS::Serverless::StateMachine in the ResultPath throws incorrect E0000 error
StateMachines allow for a null value in the ResultPath Property to [pass input directly to the output](https://docs.aws.amazon.com/step-functions/latest/dg/input-output-resultpath.html)
Below is a minimal example of a te... | Thanks for submitting this issue.
For my tracking this is the translated template. This gets translated to string which masks the null to the CloudFormation service. The cfn-lint ordering may be adjust to handle this situation correctly.
```
"DefinitionString": {
"Fn::Join": [
"\n",
... | 2022-03-25T19:54:53Z | [] | [] |
aws-cloudformation/cfn-lint | 2,253 | aws-cloudformation__cfn-lint-2253 | [
"2063"
] | bc2dff3bb97f0a95c35c6daedbf4e3a573f3d171 | diff --git a/src/cfnlint/rules/resources/properties/Properties.py b/src/cfnlint/rules/resources/properties/Properties.py
--- a/src/cfnlint/rules/resources/properties/Properties.py
+++ b/src/cfnlint/rules/resources/properties/Properties.py
@@ -36,7 +36,7 @@ def primitivetypecheck(self, value, primtype, proppath):
... | diff --git a/test/fixtures/templates/good/resource_properties.yaml b/test/fixtures/templates/good/resource_properties.yaml
--- a/test/fixtures/templates/good/resource_properties.yaml
+++ b/test/fixtures/templates/good/resource_properties.yaml
@@ -740,3 +740,14 @@ Resources:
Status: Enabled
... | E3012 Property should be of type Json - incorrectly flagging official examples
*cfn-lint version:*
0.51.0
*Description of issue.*
After upgrading to 0.51.0 today, we are now seeing new lint issues. Specifically `E3012 Property should be of type Json` on the parameters section of `AWS::SSM::Association`
Even the e... | See pinned issue https://github.com/aws-cloudformation/cfn-lint/issues/547
@PatMyron This appears to be more than an issue of strict typing. Templates that are accepted by cloudformation are failing the linting checks.
For example, this template deploys without error
```yaml
AWSTemplateFormatVersion: '2010-09-09'
... | 2022-04-19T15:16:41Z | [] | [] |
aws-cloudformation/cfn-lint | 2,317 | aws-cloudformation__cfn-lint-2317 | [
"2313"
] | e9eee01f5f75c215ab927601b927e4b0326273ea | diff --git a/src/cfnlint/rules/resources/RetentionPeriodOnResourceTypesWithAutoExpiringContent.py b/src/cfnlint/rules/resources/RetentionPeriodOnResourceTypesWithAutoExpiringContent.py
--- a/src/cfnlint/rules/resources/RetentionPeriodOnResourceTypesWithAutoExpiringContent.py
+++ b/src/cfnlint/rules/resources/RetentionP... | diff --git a/test/fixtures/templates/bad/resources/rds/retention_period.yaml b/test/fixtures/templates/bad/resources/rds/retention_period.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/bad/resources/rds/retention_period.yaml
@@ -0,0 +1,21 @@
+Resources:
+ AuroraInstance:
+ Type: AWS::RDS::DBI... | I3013 - Incorrectly flagged for aurora-<engine> database instances
**cfn-lint version**: 0.61.3
cfn-lint is falsely flagging the missing `BackupRetentionPeriod` property and it's subsequent value from `AWS::RDS:DBInstance` for an Aurora based database instance.
This property and a set value **is not required** if... | https://github.com/aws-cloudformation/cfn-lint/issues/2311
---
(nice to see more informational rule feedback coming in, assuming https://github.com/aws-cloudformation/cfn-lint-visual-studio-code/pull/223 is surfacing them more based on that being released this week) | 2022-07-29T16:54:20Z | [] | [] |
aws-cloudformation/cfn-lint | 2,364 | aws-cloudformation__cfn-lint-2364 | [
"2363"
] | 77145d90938af9f86bb970fc973eb6c54fc9e794 | diff --git a/src/cfnlint/rules/functions/SubNotJoin.py b/src/cfnlint/rules/functions/SubNotJoin.py
--- a/src/cfnlint/rules/functions/SubNotJoin.py
+++ b/src/cfnlint/rules/functions/SubNotJoin.py
@@ -7,12 +7,34 @@
class SubNotJoin(CloudFormationLintRule):
"""Check if Join is being used with no join characters"""... | diff --git a/test/fixtures/results/public/watchmaker.json b/test/fixtures/results/public/watchmaker.json
--- a/test/fixtures/results/public/watchmaker.json
+++ b/test/fixtures/results/public/watchmaker.json
@@ -95,70 +95,6 @@
"Source": "https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrins... | Update I1022 to only suggest sub if all values can be in the sub
### CloudFormation Lint Version
0.64.1
### What operating system are you using?
All
### Describe the bug
Original feedback provided by @iann0036. Translated to an issue for tracking.
```yaml
Fn::Join:
- ""
- - Fn::Select:
- 0
... | 2022-09-08T18:36:02Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,387 | aws-cloudformation__cfn-lint-2387 | [
"2337"
] | 1c42cb657b3c65690b957d944fbf3bdfd62adb7c | diff --git a/src/cfnlint/rules/resources/properties/Properties.py b/src/cfnlint/rules/resources/properties/Properties.py
--- a/src/cfnlint/rules/resources/properties/Properties.py
+++ b/src/cfnlint/rules/resources/properties/Properties.py
@@ -2,6 +2,7 @@
Copyright Amazon.com, Inc. or its affiliates. All Rights Reserve... | diff --git a/test/integration/test_directives.py b/test/integration/test_directives.py
--- a/test/integration/test_directives.py
+++ b/test/integration/test_directives.py
@@ -36,7 +36,7 @@ class TestDirectives(BaseCliTestCase):
'LineNumber': 17
}
... | Identify capitalisation errors in property names
*cfn-lint version: 0.62.0
* Feature request:
* It can be hard to identify captalisation errors in cfn property names. It would be useful if cfn-lint would call out these things. An example is:
```
TransformFunction:
Type: AWS::Lambda::Function
Propert... | 2022-09-29T15:25:28Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,425 | aws-cloudformation__cfn-lint-2425 | [
"1194"
] | c3bf32c8f45e1dcd72216302826fccc41cda791b | diff --git a/src/cfnlint/transform.py b/src/cfnlint/transform.py
--- a/src/cfnlint/transform.py
+++ b/src/cfnlint/transform.py
@@ -105,8 +105,9 @@ def _replace_local_codeuri(self):
Transform._update_to_s3_uri('ContentUri', resource_dict)
if resource_type == 'AWS::Serverless::Applicatio... | diff --git a/test/fixtures/templates/good/transform/applications_location.yaml b/test/fixtures/templates/good/transform/applications_location.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/good/transform/applications_location.yaml
@@ -0,0 +1,11 @@
+Transform: AWS::Serverless-2016-10-31
+Resources... | AWS::Serverless::Application parameters
*Description of issue.*
When creating a `AWS::Serverless::Application` input parameters should match parameters required in the nested template.
* Supplying parameters to `AWS::Serverless::Application` resources that do not exist in the child template will succeed in creati... | @redbaron09 agreed here. We have tried not to reach out to validate things in an AWS account.
Is there a way to do this without actually querying the account?
Or maybe we need to start thinking about a way to query live accounts when requested.
Following `Location` on the local file system, reading the parame... | 2022-10-20T19:50:23Z | [] | [] |
aws-cloudformation/cfn-lint | 2,426 | aws-cloudformation__cfn-lint-2426 | [
"1267"
] | b08b8f65be2c68e833cb5db177d842ebff44f38e | diff --git a/src/cfnlint/rules/conditions/EqualsIsUseful.py b/src/cfnlint/rules/conditions/EqualsIsUseful.py
new file mode 100644
--- /dev/null
+++ b/src/cfnlint/rules/conditions/EqualsIsUseful.py
@@ -0,0 +1,44 @@
+"""
+Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+SPDX-License-Identifier: MIT-0
+... | diff --git a/test/fixtures/results/quickstart/nist_config_rules.json b/test/fixtures/results/quickstart/nist_config_rules.json
--- a/test/fixtures/results/quickstart/nist_config_rules.json
+++ b/test/fixtures/results/quickstart/nist_config_rules.json
@@ -1,4 +1,32 @@
[
+ {
+ "Filename": "test/fixtures/templa... | Add check for missing !Ref in condition
*cfn-lint version: (`cfn-lint --version`)*: cfn-lint 0.26.0
*Description of issue.*
It'd be helpful if cfn-lint had a check when parameter names or psuedo-parameters are used in conditions without a `!Ref` much like it checks for strings with `${PARAMETER}` without a `!Sub`... | 2022-10-20T21:55:21Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,428 | aws-cloudformation__cfn-lint-2428 | [
"1906"
] | 27ca3c4340ebd47e56f764cd69804fcd2490e262 | diff --git a/src/cfnlint/decode/cfn_json.py b/src/cfnlint/decode/cfn_json.py
--- a/src/cfnlint/decode/cfn_json.py
+++ b/src/cfnlint/decode/cfn_json.py
@@ -20,11 +20,13 @@ class DuplicateError(Exception):
Error thrown when the template contains duplicates
"""
- def __init__(self, message, mapping, key):
+... | diff --git a/test/fixtures/templates/bad/duplicate.json b/test/fixtures/templates/bad/duplicate.json
--- a/test/fixtures/templates/bad/duplicate.json
+++ b/test/fixtures/templates/bad/duplicate.json
@@ -19,6 +19,12 @@
"Properties" : {
"TopicName" : "deployed-topic"
}
- }
+ },
+ "MySNSTopic" : {
+ "... | Only the first two Resource Duplicate are found - E0000
*cfn-lint version: (`cfn-lint 0.45.0`) Build from source: Commit: 002b3d1*
*Description of issue.*
This issue was 1st described on #1868 and fixed on #1900
I was validating the fix and it works if there are two duplicated resources, but not if you have 3... | Yea agreed. I'm going to leave this open for tracking. Since we handle these errors in the parser we are somewhat subject to the parser can do for passing and handling errors. I think I can do this but it may take a little work to get it working the right way. | 2022-10-21T00:56:40Z | [] | [] |
aws-cloudformation/cfn-lint | 2,441 | aws-cloudformation__cfn-lint-2441 | [
"2416"
] | ae76d89ccabc4cb106df37297fa61faa5eefb312 | diff --git a/src/cfnlint/rules/resources/properties/ValuePrimitiveType.py b/src/cfnlint/rules/resources/properties/ValuePrimitiveType.py
--- a/src/cfnlint/rules/resources/properties/ValuePrimitiveType.py
+++ b/src/cfnlint/rules/resources/properties/ValuePrimitiveType.py
@@ -162,6 +162,26 @@ def check_value(self, value,... | diff --git a/test/unit/rules/resources/properties/test_value_primitive_type.py b/test/unit/rules/resources/properties/test_value_primitive_type.py
--- a/test/unit/rules/resources/properties/test_value_primitive_type.py
+++ b/test/unit/rules/resources/properties/test_value_primitive_type.py
@@ -104,3 +104,42 @@ def test... | typo not being caught in Stack Parameters
### CloudFormation Lint Version
0.67.0
### What operating system are you using?
WSL2
### Describe the bug
Type is not getting caught inside stack parameters:
```yaml
AWSTemplateFormatVersion: '2010-09-09'
Description: 'Typo not caught by cfn-lint'
Paramet... | reproduced with another property-type that was also a map of strings as well | 2022-10-25T18:08:59Z | [] | [] |
aws-cloudformation/cfn-lint | 2,466 | aws-cloudformation__cfn-lint-2466 | [
"2464"
] | 50e36b696d88cbe0f2db569b985c088492c88823 | diff --git a/src/cfnlint/rules/__init__.py b/src/cfnlint/rules/__init__.py
--- a/src/cfnlint/rules/__init__.py
+++ b/src/cfnlint/rules/__init__.py
@@ -302,9 +302,7 @@ def extend(self, more):
self.register(rule)
def __repr__(self):
- return '\n'.join(
- [rule.verbose() for rule in s... | diff --git a/test/unit/module/test_rules_collections.py b/test/unit/module/test_rules_collections.py
--- a/test/unit/module/test_rules_collections.py
+++ b/test/unit/module/test_rules_collections.py
@@ -2,6 +2,7 @@
Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
SPDX-License-Identifier: MIT-0
"""
... | Cannot list all the rules
### CloudFormation Lint Version
0.70.0
### What operating system are you using?
Windows
### Describe the bug
`cfn-lint --list-rules` throws below Error.(username is masked.)
```
Traceback (most recent call last):
File "C:\Users\${username}\AppData\Local\Programs\Python\Python39\lib... | 2022-11-02T16:36:43Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,470 | aws-cloudformation__cfn-lint-2470 | [
"2469"
] | 4cf84248e1c9818f38257adedb2944d06a3a4115 | diff --git a/src/cfnlint/config.py b/src/cfnlint/config.py
--- a/src/cfnlint/config.py
+++ b/src/cfnlint/config.py
@@ -677,7 +677,7 @@ def templates(self):
elif templates_args:
filenames = templates_args
else:
- return None
+ return ['-']
# if only one is ... | diff --git a/test/unit/module/core/test_run_cli.py b/test/unit/module/core/test_run_cli.py
--- a/test/unit/module/core/test_run_cli.py
+++ b/test/unit/module/core/test_run_cli.py
@@ -108,7 +108,7 @@ def test_template_via_stdin(self):
with patch('sys.stdin', StringIO(file_content)):
(_, filenames... | cfnlint via stdin has issues when parameters are present
### CloudFormation Lint Version
v0.70.1
### What operating system are you using?
Mac
### Describe the bug
```sh
echo 'Resources: {}' | cfn-lint --include-checks I
2022-11-03 11:14:45,106 - cfnlint.decode - ERROR - Template file not found: Non... | 2022-11-03T18:34:46Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,502 | aws-cloudformation__cfn-lint-2502 | [
"2501"
] | bb7cad6229214a48af53c2742141e08e573d1fa8 | diff --git a/src/cfnlint/graph.py b/src/cfnlint/graph.py
--- a/src/cfnlint/graph.py
+++ b/src/cfnlint/graph.py
@@ -240,6 +240,7 @@ def _add_subs(self, cfn: Any) -> None:
def _add_node(self, node_id, label, settings):
if settings.node_type in ['Parameter', 'Output']:
node_id = f'{settings.no... | diff --git a/test/unit/module/test_template.py b/test/unit/module/test_template.py
--- a/test/unit/module/test_template.py
+++ b/test/unit/module/test_template.py
@@ -53,10 +53,10 @@ def test_build_graph(self):
IamPipeline [color=black, label="IamPipeline\\n<AWS::CloudFormation::Stack>", shape=ellipse, type=Resource];... | False positive E3004 circular dependency for SAM templates
### CloudFormation Lint Version
cfn-lint 0.72.0
### What operating system are you using?
Linux
### Describe the bug
When `AWS::Serverless::Function` references an alarm in its `DeploymentPreference.Alarms` and the `AWS::CloudWatch::Alarm` references the fu... | 2022-11-25T17:52:19Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,513 | aws-cloudformation__cfn-lint-2513 | [
"2483"
] | c6252d6b815127a21c58259dbe914e864844ff44 | diff --git a/src/cfnlint/rules/resources/HardCodedArnProperties.py b/src/cfnlint/rules/resources/HardCodedArnProperties.py
--- a/src/cfnlint/rules/resources/HardCodedArnProperties.py
+++ b/src/cfnlint/rules/resources/HardCodedArnProperties.py
@@ -71,9 +71,13 @@ def match_values(self, cfn):
return results
... | diff --git a/test/fixtures/templates/good/resources/properties/hard_coded_arn_properties_sam.yaml b/test/fixtures/templates/good/resources/properties/hard_coded_arn_properties_sam.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/good/resources/properties/hard_coded_arn_properties_sam.yaml
@@ -0,0 +... | Don't validate SAM transformed resources for rule I3042
### CloudFormation Lint Version
v0.71.1
### What operating system are you using?
Mac
### Describe the bug
When SAM transforms templates it can create hardcoded ARNs based on its scenario. It would make sense to not validate those ARNs against rule I3042
### ... | 2022-12-07T05:58:06Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,525 | aws-cloudformation__cfn-lint-2525 | [
"2227"
] | 03987e8aef2044108023c57870ddc03993754918 | diff --git a/src/cfnlint/rules/functions/RelationshipConditions.py b/src/cfnlint/rules/functions/RelationshipConditions.py
--- a/src/cfnlint/rules/functions/RelationshipConditions.py
+++ b/src/cfnlint/rules/functions/RelationshipConditions.py
@@ -17,7 +17,7 @@ class RelationshipConditions(CloudFormationLintRule):
... | diff --git a/test/fixtures/templates/bad/functions/relationship_conditions.yaml b/test/fixtures/templates/bad/functions/relationship_conditions.yaml
--- a/test/fixtures/templates/bad/functions/relationship_conditions.yaml
+++ b/test/fixtures/templates/bad/functions/relationship_conditions.yaml
@@ -45,6 +45,19 @@ Resour... | Feature Request: !Sub equivalent of W1001
*cfn-lint version: 0.58.2*
I believe that `!Sub` parameters should be checked to see if they depend on conditional resources the same way W1001 checks this for `!Ref` (e.g. `SubCondParam.Value` should produce a warning). I suspect this is possible since E1019 checks for non-... | 2022-12-15T18:33:15Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,548 | aws-cloudformation__cfn-lint-2548 | [
"2537"
] | 1380fa27e35c50c6dbdfd7884ed22e46563c370c | diff --git a/src/cfnlint/rules/resources/properties/Properties.py b/src/cfnlint/rules/resources/properties/Properties.py
--- a/src/cfnlint/rules/resources/properties/Properties.py
+++ b/src/cfnlint/rules/resources/properties/Properties.py
@@ -380,6 +380,21 @@ def propertycheck(self, text, proptype, parenttype, resource... | diff --git a/test/fixtures/templates/bad/resource_properties.yaml b/test/fixtures/templates/bad/resource_properties.yaml
--- a/test/fixtures/templates/bad/resource_properties.yaml
+++ b/test/fixtures/templates/bad/resource_properties.yaml
@@ -48,3 +48,13 @@ Resources:
VpcConfig:
SubnetIds: !ImportValue ... | E3002 false positives with intrinsics returning complex types
### CloudFormation Lint Version
0.72.5
### What operating system are you using?
Linux (Fedora)
### Describe the bug
When using intrinsic functions to retrieve complex (ie structured) data from custom resources for other resources E3002 incorrectly marks... | Yea I think we are handling custom resources for simple types but not for complex types. Let me double check it and correct it. | 2023-01-06T00:07:54Z | [] | [] |
aws-cloudformation/cfn-lint | 2,649 | aws-cloudformation__cfn-lint-2649 | [
"2648"
] | 7192944b5840321f3b3115cd6427e4071cdee2b7 | diff --git a/src/cfnlint/conditions/conditions.py b/src/cfnlint/conditions/conditions.py
--- a/src/cfnlint/conditions/conditions.py
+++ b/src/cfnlint/conditions/conditions.py
@@ -115,9 +115,15 @@ def _build_cnf(
if param.hash not in allowed_values:
continue
... | diff --git a/test/unit/module/conditions/test_conditions.py b/test/unit/module/conditions/test_conditions.py
--- a/test/unit/module/conditions/test_conditions.py
+++ b/test/unit/module/conditions/test_conditions.py
@@ -127,7 +127,7 @@ def test_check_never_false(self):
],
)
- def test_check_ca... | ValueError: list.remove(x): x not in list
### CloudFormation Lint Version
0.76.0
### What operating system are you using?
macOS
### Describe the bug
We run latest `cfn-lint` on all templates in the [AWS SAM repository](https://github.com/aws/serverless-application-model/); looks like 0.76.0 introduced a ... | Working on the issue but also found a use case for a new rule.
This is one of those scenarios of an always False case.
```
"Conditions": {
"CreateProdResources": {
"Fn::Equals": [
{
"Ref": "InstanceTypeParameter"
},
"prod"
]
}
},
...
"Parameters": ... | 2023-03-27T19:12:05Z | [] | [] |
aws-cloudformation/cfn-lint | 2,661 | aws-cloudformation__cfn-lint-2661 | [
"2658"
] | 792406f07bda48ac94e598cb2a068b0a76ba78b0 | diff --git a/src/cfnlint/transform.py b/src/cfnlint/transform.py
--- a/src/cfnlint/transform.py
+++ b/src/cfnlint/transform.py
@@ -218,7 +218,7 @@ def _update_to_s3_uri(
if isinstance(uri_property, dict):
if len(uri_property) == 1:
for k in uri_property.keys():
- ... | diff --git a/test/fixtures/templates/good/transform/function_use_s3_uri.yaml b/test/fixtures/templates/good/transform/function_use_s3_uri.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/good/transform/function_use_s3_uri.yaml
@@ -0,0 +1,28 @@
+AWSTemplateFormatVersion: "2010-09-09"
+Transform:
+ ... | False positive E0001 for CodeUri in AWS::Serverless::Function
### CloudFormation Lint Version
cfn-lint 0.76.1
### What operating system are you using?
Mac
### Describe the bug
cfn-lint gives a false-positive error when CodeUri is an S3 URI.
```E0001 Error transforming template: Resource with id [rCustomAuthoriz... | 2023-04-03T19:38:29Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,665 | aws-cloudformation__cfn-lint-2665 | [
"2664"
] | 7b442c881c912cb166ea3e7463a499334823d625 | diff --git a/src/cfnlint/languageExtensions.py b/src/cfnlint/languageExtensions.py
--- a/src/cfnlint/languageExtensions.py
+++ b/src/cfnlint/languageExtensions.py
@@ -29,7 +29,11 @@ def validate_pseudo_parameters(
):
if isinstance(fn_object_val, dict):
ref = "Ref"
- ref_list = [val... | diff --git a/test/fixtures/templates/good/functions_findinmap_default_value.yaml b/test/fixtures/templates/good/functions_findinmap_default_value.yaml
--- a/test/fixtures/templates/good/functions_findinmap_default_value.yaml
+++ b/test/fixtures/templates/good/functions_findinmap_default_value.yaml
@@ -75,6 +75,7 @@ Res... | cfn-lint throws error when !ToJsonString contains int value
### CloudFormation Lint Version
0.76.2
### What operating system are you using?
Ubuntu
### Describe the bug
Unexpected internal error during linting of rule E1031, involving `ToJsonString` of numerical value
```
2023-04-06 20:20:31,922 - cfnlint - DEB... | 2023-04-06T14:56:17Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,666 | aws-cloudformation__cfn-lint-2666 | [
"2596"
] | 8d59393e6462cf6a1869edc7451871b34c9dd75a | diff --git a/scripts/fix_data_files.py b/scripts/fix_data_files.py
--- a/scripts/fix_data_files.py
+++ b/scripts/fix_data_files.py
@@ -18,6 +18,7 @@
"AdditionalSpecs",
"CfnLintCli",
"Serverless",
+ "ProviderSchemasPatches",
]
for module in modules:
diff --git a/setup.py b/setup.py
--- a/setup.py
+... | diff --git a/test/integration/test_data_files.py b/test/integration/test_data_files.py
--- a/test/integration/test_data_files.py
+++ b/test/integration/test_data_files.py
@@ -21,6 +21,7 @@ def setUp(self) -> None:
"AdditionalSpecs",
"CfnLintCli",
"Serverless",
+ "Additi... | Missing ChecksumAlgorithm in OptionalFields for InventoryConfigurations in S3 Bucket
### CloudFormation Lint Version
0.73.1
### What operating system are you using?
Mac
### Describe the bug
[Serverless IDE] E3030: You must specify a valid value for OptionalFields (ChecksumAlgorithm). Valid values are ["Size", "Las... | enum being pulled in automatically from [resource provider schema](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/resource-type-schemas.html):
```
"enum" : [ "Size", "LastModifiedDate", "StorageClass", "ETag", "IsMultipartUploaded", "ReplicationStatus", "EncryptionStatus", "ObjectLockRetainUntilDate",... | 2023-04-06T19:12:55Z | [] | [] |
aws-cloudformation/cfn-lint | 2,682 | aws-cloudformation__cfn-lint-2682 | [
"2676"
] | 24e6f29029bd64d36e35e2a3db6a30a162466414 | diff --git a/src/cfnlint/rules/resources/lmbd/ZipPackageRequiredProperties.py b/src/cfnlint/rules/resources/lmbd/ZipPackageRequiredProperties.py
new file mode 100644
--- /dev/null
+++ b/src/cfnlint/rules/resources/lmbd/ZipPackageRequiredProperties.py
@@ -0,0 +1,76 @@
+"""
+Copyright Amazon.com, Inc. or its affiliates. ... | diff --git a/test/fixtures/templates/bad/resources/lambda/required_properties.yaml b/test/fixtures/templates/bad/resources/lambda/required_properties.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/bad/resources/lambda/required_properties.yaml
@@ -0,0 +1,32 @@
+AWSTemplateFormatVersion: '2010-09-0... | New rule for package command and Lambda
### Is this feature request related to a new rule or cfn-lint capabilities?
_No response_
### Describe the feature you'd like to request
Error message when using the package command and Lambda: `Runtime and Handler are mandatory parameters for functions created with deployment... | 2023-04-11T14:24:34Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,691 | aws-cloudformation__cfn-lint-2691 | [
"2310"
] | 2b354fb3da4613bbfab526b87454ee1d10a2a931 | diff --git a/src/cfnlint/rules/resources/ectwo/SecurityGroupIngress.py b/src/cfnlint/rules/resources/ectwo/SecurityGroupIngress.py
--- a/src/cfnlint/rules/resources/ectwo/SecurityGroupIngress.py
+++ b/src/cfnlint/rules/resources/ectwo/SecurityGroupIngress.py
@@ -36,19 +36,6 @@ def check_ingress_rule(self, vpc_id, prope... | diff --git a/test/unit/rules/resources/ec2/test_sg_ingress.py b/test/unit/rules/resources/ec2/test_sg_ingress.py
--- a/test/unit/rules/resources/ec2/test_sg_ingress.py
+++ b/test/unit/rules/resources/ec2/test_sg_ingress.py
@@ -27,5 +27,5 @@ def test_file_positive(self):
def test_file_negative(self):
"""Te... | E2506 prevents using SourceSecurityGroupId for non-vpc security groups
https://github.com/aws-cloudformation/cfn-lint/blob/4a7af2bd53a9ad1ccaba3a509437c53102ade522/src/cfnlint/rules/resources/ectwo/SecurityGroupIngress.py#L33-L40
I couldn't see any reason in the [cloudformation reference](https://docs.aws.amazon.com... | Yea it'd be nice to know what this rule is for. Also getting this error..
This is an older rule and needs a refresh as there have been some changes from ec2-classic.
Validated the following scenarios:
* `SourceSecurityGroupId` works for Default VPC (when `VpcId` is NOTspecified)
* `SourceSecurityGroupName` works... | 2023-04-13T20:51:14Z | [] | [] |
aws-cloudformation/cfn-lint | 2,693 | aws-cloudformation__cfn-lint-2693 | [
"2690"
] | e86bd05bba9cf2d2f514eff01c27e048cfb8975a | diff --git a/src/cfnlint/data/schemas/extensions/aws_ec2_vpc/__init__.py b/src/cfnlint/data/schemas/extensions/aws_ec2_vpc/__init__.py
new file mode 100644
diff --git a/src/cfnlint/data/schemas/nested/__init__.py b/src/cfnlint/data/schemas/nested/__init__.py
new file mode 100644
--- /dev/null
+++ b/src/cfnlint/data/sch... | diff --git a/test/unit/module/jsonschema/test_validators.py b/test/unit/module/jsonschema/test_validators.py
--- a/test/unit/module/jsonschema/test_validators.py
+++ b/test/unit/module/jsonschema/test_validators.py
@@ -4,15 +4,29 @@
"""
import unittest
-from cfnlint.jsonschema.validator import CfnValidator
+from js... | A VPC needs to have CIDR blocks specified
### Is this feature request related to a new rule or cfn-lint capabilities?
rules
### Describe the feature you'd like to request
```
AWSTemplateFormatVersion: '2010-09-09'
Resources:
Vpc:
Type: AWS::EC2::VPC
```
### Describe the solution you'd like
I want to cat... | 2023-04-13T21:25:55Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,720 | aws-cloudformation__cfn-lint-2720 | [
"2719"
] | 64164b5d58ddbef2d4b2ffee216452d48dc527d9 | diff --git a/src/cfnlint/runner.py b/src/cfnlint/runner.py
--- a/src/cfnlint/runner.py
+++ b/src/cfnlint/runner.py
@@ -5,6 +5,7 @@
import logging
from typing import List, Optional, Sequence, Union
+from cfnlint.conditions import Conditions
from cfnlint.graph import Graph
from cfnlint.rules import Match, Rule... | diff --git a/test/fixtures/templates/issues/sam_w_conditions.yaml b/test/fixtures/templates/issues/sam_w_conditions.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/issues/sam_w_conditions.yaml
@@ -0,0 +1,413 @@
+AWSTemplateFormatVersion: 2010-09-09
+Transform: AWS::Serverless-2016-10-31
+
+Paramet... | E0002 Unknown exception while processing rule E3001: 'ServerlessCodeDeployCondition'
### CloudFormation Lint Version
0.77.3
### What operating system are you using?
Ubuntu
### Describe the bug
Suddenly cfn-lint fails to validate a template that haven't been touched for several months. cfn-lint seems to b... | 2023-04-28T15:07:08Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,757 | aws-cloudformation__cfn-lint-2757 | [
"2756"
] | 431cf4fb9fefdfec25cb4cb69005f4dd064421ba | diff --git a/src/cfnlint/rules/custom/__init__.py b/src/cfnlint/rules/custom/__init__.py
--- a/src/cfnlint/rules/custom/__init__.py
+++ b/src/cfnlint/rules/custom/__init__.py
@@ -42,73 +42,79 @@ def process_sets(raw_value):
return raw_value
line = line.rstrip()
- rule_id = lineNumber + 9000
- line... | diff --git a/test/fixtures/custom_rules/good/custom_rule_perfect.txt b/test/fixtures/custom_rules/good/custom_rule_perfect.txt
--- a/test/fixtures/custom_rules/good/custom_rule_perfect.txt
+++ b/test/fixtures/custom_rules/good/custom_rule_perfect.txt
@@ -1,3 +1,4 @@
+#This is a comment to ensure comments in custom rule... | New Lines in Custom Rules file causes failures
### CloudFormation Lint Version
cfn-lint 0.77.6
### What operating system are you using?
Mac
### Describe the bug
Similar to the issue reported in https://github.com/aws-cloudformation/cfn-lint/issues/2069, adding a new blank line in the custom rules file causes `cfn-... | 2023-06-04T18:29:09Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,780 | aws-cloudformation__cfn-lint-2780 | [
"2778"
] | 582258aaea531dc8c9a242248cd5b23eb95c7f92 | diff --git a/src/cfnlint/rules/functions/Cidr.py b/src/cfnlint/rules/functions/Cidr.py
--- a/src/cfnlint/rules/functions/Cidr.py
+++ b/src/cfnlint/rules/functions/Cidr.py
@@ -49,7 +49,10 @@ def check_ip_block(self, value, path):
)
)
... | diff --git a/test/fixtures/templates/good/functions/cidr.yaml b/test/fixtures/templates/good/functions/cidr.yaml
--- a/test/fixtures/templates/good/functions/cidr.yaml
+++ b/test/fixtures/templates/good/functions/cidr.yaml
@@ -13,6 +13,8 @@ Parameters:
MaxValue: 6
Size:
Type: String
+ FirstTierSubnet1CIDR... | E0002: Unknown exception while processing rule E1024: 'list' object has no attribute 'path'
### CloudFormation Lint Version
cfn-lint 0.77.10
### What operating system are you using?
Mac
### Describe the bug
When validation checks run on a the Cidr function `!Cidr [ ipBlock, count, cidrBits ]`, the count and cidrBi... | Found the issue and working to correct it. | 2023-06-30T17:34:19Z | [] | [] |
aws-cloudformation/cfn-lint | 2,786 | aws-cloudformation__cfn-lint-2786 | [
"2181"
] | b7bc622d556d4b98fa97226700174e05bc9cd669 | diff --git a/src/cfnlint/helpers.py b/src/cfnlint/helpers.py
--- a/src/cfnlint/helpers.py
+++ b/src/cfnlint/helpers.py
@@ -77,9 +77,9 @@
re.I | re.S,
)
REGEX_DYN_REF = re.compile(r"^.*{{resolve:.+}}.*$")
-REGEX_DYN_REF_SSM = re.compile(r"^.*{{resolve:ssm:[a-zA-Z0-9_\.\-/]+:\d+}}.*$")
+REGEX_DYN_REF_SSM = re.comp... | diff --git a/test/fixtures/templates/bad/functions_split.yaml b/test/fixtures/templates/bad/functions_split.yaml
--- a/test/fixtures/templates/bad/functions_split.yaml
+++ b/test/fixtures/templates/bad/functions_split.yaml
@@ -31,3 +31,10 @@ Resources:
AvailabilityZone: !Select
- 0
- Fn::Split: {Re... | Alert when doing a split on a dynamic reference
You can dynamic reference a `StringList` but it is read in as a comma delimited singular string. [Docs](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/dynamic-references.html#dynamic-references-ssm)
You cannot put it back into a list by doing `!Split ['... | 2023-07-03T22:53:02Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,891 | aws-cloudformation__cfn-lint-2891 | [
"2890"
] | 60714ec0be0126f33b9f9b60b860f359b184ed2d | diff --git a/src/cfnlint/rules/resources/properties/Exclusive.py b/src/cfnlint/rules/resources/properties/Exclusive.py
--- a/src/cfnlint/rules/resources/properties/Exclusive.py
+++ b/src/cfnlint/rules/resources/properties/Exclusive.py
@@ -40,7 +40,7 @@ def check(self, properties, exclusions, path, cfn):
... | diff --git a/test/fixtures/templates/good/resources/properties/exclusive.yaml b/test/fixtures/templates/good/resources/properties/exclusive.yaml
--- a/test/fixtures/templates/good/resources/properties/exclusive.yaml
+++ b/test/fixtures/templates/good/resources/properties/exclusive.yaml
@@ -5,4 +5,47 @@ Resources:
... | E2520 false positive for CloudWatch Alarm with expression
### CloudFormation Lint Version
0.80.3
### What operating system are you using?
MacOS
### Describe the bug
A valid CloudWatch alarm that uses a metrics expression is resulting in an E2520 false positive. The alarm was defined in the CloudWatch co... | 2023-09-27T22:54:04Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,905 | aws-cloudformation__cfn-lint-2905 | [
"2903"
] | ae09aed9effc999188cde057529be23dafc87a7d | diff --git a/src/cfnlint/rules/resources/lmbd/SnapStart.py b/src/cfnlint/rules/resources/lmbd/SnapStart.py
new file mode 100644
--- /dev/null
+++ b/src/cfnlint/rules/resources/lmbd/SnapStart.py
@@ -0,0 +1,77 @@
+"""
+Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+SPDX-License-Identifier: MIT-0
+"""... | diff --git a/test/fixtures/templates/bad/resources/lambda/snapstart-enabled.yaml b/test/fixtures/templates/bad/resources/lambda/snapstart-enabled.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/bad/resources/lambda/snapstart-enabled.yaml
@@ -0,0 +1,24 @@
+Resources:
+ LambdaRole:
+ Type: AWS::... | New rule to validate lambda SnapStart configuration
### Is this feature request related to a new rule or cfn-lint capabilities?
rules
### Describe the feature you'd like to request
When configuring SnapStart you also need to configure a version.
A warning level rule will validate that when SnapStart is configured... | 2023-10-12T17:17:06Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,912 | aws-cloudformation__cfn-lint-2912 | [
"2911"
] | 00ee90b24a6b380d8abaa886eaf3a23f0d545282 | diff --git a/src/cfnlint/rules/resources/lmbd/SnapStartEnabled.py b/src/cfnlint/rules/resources/lmbd/SnapStartEnabled.py
--- a/src/cfnlint/rules/resources/lmbd/SnapStartEnabled.py
+++ b/src/cfnlint/rules/resources/lmbd/SnapStartEnabled.py
@@ -23,7 +23,7 @@ def __init__(self):
self.resource_property_types.appen... | diff --git a/test/fixtures/templates/good/resources/lambda/snapstart-supported.yaml b/test/fixtures/templates/good/resources/lambda/snapstart-supported.yaml
--- a/test/fixtures/templates/good/resources/lambda/snapstart-supported.yaml
+++ b/test/fixtures/templates/good/resources/lambda/snapstart-supported.yaml
@@ -1,3 +... | E0002: Unknown exception while processing rule E2530: 'dict' object has no attribute 'startswith'
### CloudFormation Lint Version
0.82.0
### What operating system are you using?
windows 11
### Describe the bug
receive the E2530 error even though i dont have SnapStart in my lambda resource
### Expected behav... | Should have a fix out shortly. | 2023-10-17T20:42:07Z | [] | [] |
aws-cloudformation/cfn-lint | 2,927 | aws-cloudformation__cfn-lint-2927 | [
"2925"
] | 72de42964f8187ac58df755219e516e570d5a52c | diff --git a/src/cfnlint/rules/resources/properties/ListDuplicatesAllowed.py b/src/cfnlint/rules/resources/properties/ListDuplicatesAllowed.py
--- a/src/cfnlint/rules/resources/properties/ListDuplicatesAllowed.py
+++ b/src/cfnlint/rules/resources/properties/ListDuplicatesAllowed.py
@@ -21,6 +21,10 @@ class ListDuplicat... | diff --git a/test/fixtures/templates/good/resources/properties/list_duplicates_allowed.yaml b/test/fixtures/templates/good/resources/properties/list_duplicates_allowed.yaml
--- a/test/fixtures/templates/good/resources/properties/list_duplicates_allowed.yaml
+++ b/test/fixtures/templates/good/resources/properties/list_d... | `I3037` false positives in `AWS::ECS::TaskDefinition.ContainerDefinitions.Command`
### CloudFormation Lint Version
0.83.0
### What operating system are you using?
Mac
### Describe the bug
`I3037` issues (*List has a duplicate value*) are reported if the command specified in `AWS::ECS::TaskDefinition.ContainerDefin... | 2023-10-24T16:56:22Z | [] | [] | |
aws-cloudformation/cfn-lint | 2,967 | aws-cloudformation__cfn-lint-2967 | [
"2964"
] | d874e5899bef1cd8bb6330b4cff9f160f5d823fb | diff --git a/src/cfnlint/rules/resources/cloudfront/Aliases.py b/src/cfnlint/rules/resources/cloudfront/Aliases.py
--- a/src/cfnlint/rules/resources/cloudfront/Aliases.py
+++ b/src/cfnlint/rules/resources/cloudfront/Aliases.py
@@ -4,7 +4,7 @@
"""
import regex as re
-from cfnlint.helpers import FUNCTIONS
+from cfnli... | diff --git a/test/fixtures/templates/good/resources/cloudfront/aliases.yaml b/test/fixtures/templates/good/resources/cloudfront/aliases.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/good/resources/cloudfront/aliases.yaml
@@ -0,0 +1,23 @@
+AWSTemplateFormatVersion: 2010-09-09
+Resources:
+ Cloud... | Invalid Aliases when using SSM dynamic references
### CloudFormation Lint Version
0.83.0
### What operating system are you using?
Mac
### Describe the bug
When using a dynamic reference to resolve the Alias domain, cfn-lint fails indicating it's an invalid alias. Shouldn't the code check if this is a `RE... | 2023-12-07T18:43:08Z | [] | [] | |
aws-cloudformation/cfn-lint | 3,001 | aws-cloudformation__cfn-lint-3001 | [
"3000"
] | 6e39e8cf67d0c6fe5769d56ab4a8d8152e491354 | diff --git a/src/cfnlint/rules/resources/ectwo/SecurityGroupIngress.py b/src/cfnlint/rules/resources/ectwo/SecurityGroupIngress.py
deleted file mode 100644
--- a/src/cfnlint/rules/resources/ectwo/SecurityGroupIngress.py
+++ /dev/null
@@ -1,85 +0,0 @@
-"""
-Copyright Amazon.com, Inc. or its affiliates. All Rights Reserv... | diff --git a/test/unit/rules/resources/ec2/test_sg_ingress.py b/test/unit/rules/resources/ec2/test_sg_ingress.py
deleted file mode 100644
--- a/test/unit/rules/resources/ec2/test_sg_ingress.py
+++ /dev/null
@@ -1,31 +0,0 @@
-"""
-Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
-SPDX-License-Identifie... | E2506 will fail when using default vpc
### CloudFormation Lint Version
latest
### What operating system are you using?
Mac
### Describe the bug
False positive for rule E2506 when using security group names with a default vpc
### Expected behavior
We should be able to specify a default security group name with a ... | 2024-01-05T21:35:28Z | [] | [] | |
aws-cloudformation/cfn-lint | 3,017 | aws-cloudformation__cfn-lint-3017 | [
"2141"
] | 2660e6cf0a6e22a12efdff30f6fb412ad82c2aef | diff --git a/src/cfnlint/rules/resources/events/RuleScheduleExpression.py b/src/cfnlint/rules/resources/events/RuleScheduleExpression.py
--- a/src/cfnlint/rules/resources/events/RuleScheduleExpression.py
+++ b/src/cfnlint/rules/resources/events/RuleScheduleExpression.py
@@ -25,29 +25,43 @@ def check_rate(self, value, p... | diff --git a/test/fixtures/templates/bad/resources/events/rule_schedule_expression.yaml b/test/fixtures/templates/bad/resources/events/rule_schedule_expression.yaml
--- a/test/fixtures/templates/bad/resources/events/rule_schedule_expression.yaml
+++ b/test/fixtures/templates/bad/resources/events/rule_schedule_expressio... | Doesn't catch invalid `rate(1 hours)`
*cfn-lint version: (`cfn-lint --version`)*
0.44.7
*Description of issue.*
cfn-lint doesn't recognize that this ScheduledExpression is invalid (should be `rate(1 hour)`)
```yaml
ExampleRule:
Type: AWS::Events::Rule
Properties:
Description: desc
N... | 2024-01-18T18:47:57Z | [] | [] | |
aws-cloudformation/cfn-lint | 3,060 | aws-cloudformation__cfn-lint-3060 | [
"3047"
] | 7cabf206313e8b1b0e46eaa0e1d1af1b1b6ad318 | diff --git a/src/cfnlint/rules/resources/properties/PropertiesTemplated.py b/src/cfnlint/rules/resources/properties/PropertiesTemplated.py
--- a/src/cfnlint/rules/resources/properties/PropertiesTemplated.py
+++ b/src/cfnlint/rules/resources/properties/PropertiesTemplated.py
@@ -60,6 +60,9 @@ def match_resource_properti... | diff --git a/test/fixtures/templates/good/resources/properties/templated_code_sam.yaml b/test/fixtures/templates/good/resources/properties/templated_code_sam.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/good/resources/properties/templated_code_sam.yaml
@@ -0,0 +1,6 @@
+Transform: AWS::Serverles... | Support SAM `AWS::Serverless::Application` without triggering W3002
### Is this feature request related to a new rule or cfn-lint capabilities?
rules, New capability
### Describe the feature you'd like to request
This is similar to https://github.com/aws-cloudformation/cfn-lint/issues/2297. When using a SAM template... | 2024-02-16T16:18:53Z | [] | [] | |
aws-cloudformation/cfn-lint | 3,061 | aws-cloudformation__cfn-lint-3061 | [
"2622"
] | 33983345c7eee06dd04e945ceac6112ae9cc5279 | diff --git a/src/cfnlint/template/template.py b/src/cfnlint/template/template.py
--- a/src/cfnlint/template/template.py
+++ b/src/cfnlint/template/template.py
@@ -7,7 +7,7 @@
import logging
from copy import deepcopy
-from typing import List, Union
+from typing import Any, Dict, List, Union
import regex as ... | diff --git a/test/fixtures/registry/custom/resource.json b/test/fixtures/registry/custom/resource.json
new file mode 100644
--- /dev/null
+++ b/test/fixtures/registry/custom/resource.json
@@ -0,0 +1,138 @@
+{
+ "typeName": "Initech::TPS::Report",
+ "description": "An example resource schema demonstrating some bas... | CloudFormation Registry resource support - GetAtt rules broken
### CloudFormation Lint Version
cfn-lint 0.73.1
### What operating system are you using?
Mac
### Describe the bug
Currently the `-s` switch brings in the schemas for custom resource extensions. This allow some cfn-lint rules to work but not all.
As... | Is there any update on this issue? Having similar issues with GetAtt. | 2024-02-16T19:01:44Z | [] | [] |
aws-cloudformation/cfn-lint | 3,073 | aws-cloudformation__cfn-lint-3073 | [
"3067"
] | 4a3dd987bdbd5c35113ab5b88f48fbfd9cd506dd | diff --git a/src/cfnlint/decode/cfn_yaml.py b/src/cfnlint/decode/cfn_yaml.py
--- a/src/cfnlint/decode/cfn_yaml.py
+++ b/src/cfnlint/decode/cfn_yaml.py
@@ -88,6 +88,19 @@ def construct_yaml_map(self, node):
key = self.construct_object(key_node, False)
value = self.construct_object(value_node, F... | diff --git a/test/unit/module/decode/test_decode.py b/test/unit/module/decode/test_decode.py
--- a/test/unit/module/decode/test_decode.py
+++ b/test/unit/module/decode/test_decode.py
@@ -11,7 +11,9 @@
import yaml
from yaml.scanner import ScannerError
-import cfnlint.decode.decode # pylint: disable=E0401
+import cf... | "null" as Parameter Name Throws Incorrect Error
### CloudFormation Lint Version
0.85.2_1
### What operating system are you using?
Mac
### Describe the bug
Setting a Parameter name to "null" produces incorrect or misleading errors:
"E0002 Unknown exception while processing rule E2011: object of type 'NoneType' has... | 2024-02-23T22:10:28Z | [] | [] | |
aws-cloudformation/cfn-lint | 3,131 | aws-cloudformation__cfn-lint-3131 | [
"3130"
] | 8d1343be8303e65d42d51841c5c7071eb6d4cc54 | diff --git a/src/cfnlint/template/transforms/_language_extensions.py b/src/cfnlint/template/transforms/_language_extensions.py
--- a/src/cfnlint/template/transforms/_language_extensions.py
+++ b/src/cfnlint/template/transforms/_language_extensions.py
@@ -156,7 +156,7 @@ def _walk(self, item: Any, params: MutableMapping... | diff --git a/test/unit/module/template/transforms/test_language_extensions.py b/test/unit/module/template/transforms/test_language_extensions.py
--- a/test/unit/module/template/transforms/test_language_extensions.py
+++ b/test/unit/module/template/transforms/test_language_extensions.py
@@ -182,6 +182,32 @@ def test_bad... | W8003 False positive
### CloudFormation Lint Version
0.86.0
### What operating system are you using?
mac
### Describe the bug
lint raises a W8003 for the below template, but I don't think it's true that it will always return True or False. It checks whether the value obtained from the mapping for the specified env... | 2024-04-03T17:37:12Z | [] | [] | |
aws-cloudformation/cfn-lint | 3,169 | aws-cloudformation__cfn-lint-3169 | [
"3168"
] | fb55eeee02581aaaf40c9a7b87880c6db4a97aaa | diff --git a/src/cfnlint/rules/conditions/Configuration.py b/src/cfnlint/rules/conditions/Configuration.py
--- a/src/cfnlint/rules/conditions/Configuration.py
+++ b/src/cfnlint/rules/conditions/Configuration.py
@@ -26,8 +26,10 @@ class Configuration(CloudFormationLintRule):
def match(self, cfn):
matches =... | diff --git a/test/fixtures/templates/bad/conditions_type.yaml b/test/fixtures/templates/bad/conditions_type.yaml
new file mode 100644
--- /dev/null
+++ b/test/fixtures/templates/bad/conditions_type.yaml
@@ -0,0 +1,8 @@
+AWSTemplateFormatVersion: "2010-09-09"
+Conditions:
+Resources:
+ myTopic:
+ Type: AWS::SNS:... | Condition Specified but with no condition passes linting but fails deploy
### CloudFormation Lint Version
0.83.1
### What operating system are you using?
mac/ubuntu
### Describe the bug
in a cfn template if you specify root level item `Conditions` but have no conditions this passes cfn-lint but always fa... | This breaks pretty hard in v1 but yea we are missing some extra logic here in v0. Probably an unfortunate change to allowing null values and not building up some of the other logic. | 2024-04-24T22:09:25Z | [] | [] |
aws-cloudformation/cfn-lint | 3,176 | aws-cloudformation__cfn-lint-3176 | [
"3174"
] | 691836389149bc0047b4216c0022d17356321239 | diff --git a/src/cfnlint/decode/node.py b/src/cfnlint/decode/node.py
--- a/src/cfnlint/decode/node.py
+++ b/src/cfnlint/decode/node.py
@@ -76,7 +76,6 @@ class node_class(cls):
def __init__(
self, x, start_mark: Mark | None = None, end_mark: Mark | None = None
):
- LOGGER.debug(... | diff --git a/test/unit/module/template/transforms/test_language_extensions.py b/test/unit/module/template/transforms/test_language_extensions.py
--- a/test/unit/module/template/transforms/test_language_extensions.py
+++ b/test/unit/module/template/transforms/test_language_extensions.py
@@ -10,9 +10,9 @@
from cfnlint.t... | Validaton error for `Fn::ForEach` - `contains invalid characters`
### CloudFormation Lint Version
cfn-lint 0.86.4
### What operating system are you using?
Ubuntu
### Describe the bug
I am getting false validation errors when using `Fn::ForEach` :
```
E3031 TargetId contains invalid characters (Patter... | I need to evaluate some options to resolve this. Thanks for reporting it. | 2024-04-29T20:13:12Z | [] | [] |
aws-cloudformation/cfn-lint | 3,224 | aws-cloudformation__cfn-lint-3224 | [
"3223"
] | 10b6a8b517c0e90ed825fc207982c67506fe8bf6 | diff --git a/src/cfnlint/rules/resources/properties/Properties.py b/src/cfnlint/rules/resources/properties/Properties.py
--- a/src/cfnlint/rules/resources/properties/Properties.py
+++ b/src/cfnlint/rules/resources/properties/Properties.py
@@ -493,6 +493,26 @@ def propertycheck(self, text, proptype, parenttype, resource... | diff --git a/test/fixtures/templates/bad/object_should_be_list.yaml b/test/fixtures/templates/bad/object_should_be_list.yaml
--- a/test/fixtures/templates/bad/object_should_be_list.yaml
+++ b/test/fixtures/templates/bad/object_should_be_list.yaml
@@ -677,3 +677,19 @@ Resources:
- - AttributeName: !Ref Partitio... | [AWS::SSM::Association] - [BUG] - cfn-lint doesn't recognize `Values: expected type: JSONArray, found: String`
### CloudFormation Lint Version
cfn-lint 0.87.1
### What operating system are you using?
Windows 11
### Describe the bug
cfn-lint doesn't recognize the following error message:
```
Resource handler re... | Hmm, should be able to find this one. I wonder if we aren't handling JSON values well. I'll look into this.
Already fixed in v1 but is a bug in v0. | 2024-05-09T01:16:44Z | [] | [] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.